Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "Notify about these words" option #19

Closed
vlad-timotei opened this issue Jul 11, 2021 · 0 comments
Closed

Drop "Notify about these words" option #19

vlad-timotei opened this issue Jul 11, 2021 · 0 comments
Milestone
1.4

Comments

@vlad-timotei
Copy link
Owner

vlad-timotei commented Jul 11, 2021 •
edited
Loading

This option is mostly redundant, as user already has "Prevent saving these words" that generates a warning.
There is no need to generate a notification and not a warning if a certain word is "bad".
If it's a false positive result, then user can always check "Save / approve with warnings" or even remove the word from the list, if the percent of false positive results is too high

image

This gives the chance to keep a minimum number of options while implementing #14 (comment)
vlad-timotei added a commit that referenced this issue Jul 11, 2021
@vlad-timotei
Count and match strings
653f9b6 
Adds an option to set a list of strings that will be counted in original and translation and then matched. A warning will be generated if counts don't match.

Replaces regex in checks with optimized function, where possible. Up to 10 times faster, according to author.

Removes the break in finding the warning words after the first word is found.

Removes the "Notify about these words" option.

Fixes:
#14,
#19,
#8
@vlad-timotei vlad-timotei added this to the 1.4 milestone Jul 11, 2021
vlad-timotei added a commit that referenced this issue Jul 18, 2021
@vlad-timotei
Count and match strings
debc464 
Adds an option to set a list of strings that will be counted in original and translation and then matched. A warning will be generated if counts don't match.

Replaces regex in checks with optimized function, where possible. Up to 10 times faster, according to author.

Removes the break in finding the warning words after the first word is found.

Removes the "Notify about these words" option.

Fixes:
#14,
#19,
#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
1 participant
@vlad-timotei