Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new ProxyFactory to use a ConnectionDecorator object instead of a Proxy #20

Closed
vladmihalcea opened this issue Jul 3, 2015 · 0 comments
Closed

Add a new ProxyFactory to use a ConnectionDecorator object instead of a Proxy #20

vladmihalcea opened this issue Jul 3, 2015 · 0 comments
Assignees
@vladmihalcea
Labels
enhancement
Milestone
1.2.3

Comments

@vladmihalcea
Copy link
Owner

For performance reasons, a Proxy will never be as fast as an actual delegate class. While the Proxy allows the library to be compatible with future Java versions that keep on adding methods to the Connection class hierarchy (as we got used to it by now), the performance penalty might be to much for paying of.

The ConnectionDecorator simply delegates all calls to the actual Connection object. The newer Java 1.7 and 1.8 methods are invoked using reflection, to allow compiling the project with Java 1.6
@vladmihalcea vladmihalcea self-assigned this Jul 3, 2015
@vladmihalcea vladmihalcea added this to the 1.2.3 milestone Jul 3, 2015
@vladmihalcea vladmihalcea changed the title Add a new ProxyFactory to use a ManagedConnection delegate Add a new ProxyFactory to use a ConnectionDelegate object instead of a Proxy Jul 4, 2015
vladmihalcea added a commit that referenced this issue Jul 5, 2015
@vladmihalcea
#20 Add a new ProxyFactory to use a ConnectionDelegate object instead…
1260e4e 
… of a Proxy

Add the new flexy-pool-core-java7 module to include all Java 1.7 JDBC additions
The ConnectionDelegate abstraction is using the same Service resolving mechanims like the MetricsFactory
vladmihalcea added a commit that referenced this issue Jul 5, 2015
@vladmihalcea
#20 Add a new ProxyFactory to use a ConnectionDelegate object instead…
18589bd 
… of a Proxy

The Java 7 Connection Delegate resolver checks the runtime version
Removed Sonar issues
vladmihalcea added a commit that referenced this issue Jul 5, 2015
@vladmihalcea
#20 Add a new ProxyFactory to use a ConnectionDecorator object instea…
0718a25 
…d of a Proxy

Activate Java 7 Connection Decorator resolver for Java 8 tests
@vladmihalcea vladmihalcea changed the title Add a new ProxyFactory to use a ConnectionDelegate object instead of a Proxy Add a new ProxyFactory to use a ConnectionDecorator object instead of a Proxy Jul 5, 2015
vladmihalcea added a commit that referenced this issue Jul 5, 2015
@vladmihalcea
#20 Add a new ProxyFactory to use a ConnectionDecorator object instea…
8863fc3 
…d of a Proxy

Protect ConnectionDecoratorResolver from LinkageErrors and add test in common-adaptor
vladmihalcea added a commit that referenced this issue Jul 6, 2015
@vladmihalcea
#20 Add a new ProxyFactory to use a ConnectionDecorator object instea…
c5e5f3d 
…d of a Proxy

Fixed Sonar issues and improved code coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladmihalcea vladmihalcea

Labels
enhancement
Projects
None yet
Milestone
1.2.3
Development

No branches or pull requests
1 participant
@vladmihalcea