Skip to content

Commit 014f44e

Browse files
authored
checker: improve error message of method_call_arg_no_mut_err.vv (#15281)
1 parent c9a5896 commit 014f44e

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

vlib/v/checker/fn.v

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1609,7 +1609,7 @@ pub fn (mut c Checker) method_call(mut node ast.CallExpr) ast.Type {
16091609
to_lock, pos := c.fail_if_immutable(arg.expr)
16101610
if !param.is_mut {
16111611
tok := arg.share.str()
1612-
c.error('`$node.name` parameter `$param.name` is not `$tok`, `$tok` is not needed`',
1612+
c.error('`$node.name` parameter ${i + 1} is not `$tok`, `$tok` is not needed`',
16131613
arg.expr.pos())
16141614
} else {
16151615
if param_share != arg.share {
@@ -1624,7 +1624,7 @@ pub fn (mut c Checker) method_call(mut node ast.CallExpr) ast.Type {
16241624
} else {
16251625
if param.is_mut {
16261626
tok := arg.share.str()
1627-
c.error('method `$node.name` parameter `$param.name` is `$tok`, so use `$tok $arg.expr` instead',
1627+
c.error('method `$node.name` parameter ${i + 1} is `$tok`, so use `$tok $arg.expr` instead',
16281628
arg.expr.pos())
16291629
} else {
16301630
c.fail_if_unreadable(arg.expr, targ, 'argument')

vlib/v/checker/tests/method_call_arg_no_mut_err.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
vlib/v/checker/tests/method_call_arg_no_mut_err.vv:25:14: error: method `alarm_fkt` parameter `a` is `mut`, so use `mut last` instead
1+
vlib/v/checker/tests/method_call_arg_no_mut_err.vv:25:14: error: method `alarm_fkt` parameter 1 is `mut`, so use `mut last` instead
22
23 | c.arr << Alarm{}
33
24 | mut last := c.arr.last()
44
25 | c.alarm_fkt(last)

vlib/v/checker/tests/method_call_arg_no_mut_err.vv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module main
22

3-
type Fkt = fn (mut a Alarm)
3+
type Fkt = fn (mut Alarm)
44

55
struct Alarm {
66
x int

0 commit comments

Comments
 (0)