tools: format most examples and tutorials, add them to v test-cleancode (#9826)

Author: Lukas Neubert

cmd/tools/vtest-cleancode.v

@@ -18,12 +18,18 @@ const (
 		'examples/term.ui',
 	]
 	verify_known_failing_exceptions = [
+		// Handcrafted meaningful formatting of code parts (mostly arrays)
+		'examples/sokol/02_cubes_glsl/cube_glsl.v',
+		'examples/sokol/03_march_tracing_glsl/rt_glsl.v',
+		'examples/sokol/04_multi_shader_glsl/rt_glsl.v',
+		'examples/sokol/05_instancing_glsl/rt_glsl.v',
+		'vlib/gg/m4/graphic.v',
+		'vlib/gg/m4/m4_test.v',
+		'vlib/gg/m4/matrix.v',
 		'vlib/builtin/int_test.v' /* special number formatting that should be tested */,
+		// TODOs and unfixed vfmt bugs
 		'vlib/builtin/int.v' /* TODO byteptr: vfmt converts `pub fn (nn byteptr) str() string {` to `nn &byte` and that conflicts with `nn byte` */,
 		'vlib/builtin/string_charptr_byteptr_helpers.v' /* TODO byteptr: a temporary shim to ease the byteptr=>&byte transition */,
-		'vlib/gg/m4/graphic.v' /* has hand crafted meaningful formatting of matrices */,
-		'vlib/gg/m4/m4_test.v' /* has hand crafted meaningful formatting of matrices */,
-		'vlib/gg/m4/matrix.v' /* has hand crafted meaningful formatting of matrices */,
 		'vlib/v/tests/array_append_short_struct_test.v', /* extra empty line */
 		'vlib/v/tests/fixed_array_const_size_test.v', /* fixed arr type is changed */
 		'vlib/v/tests/fn_high_test.v', /* param name removed */
@@ -34,9 +40,13 @@ const (
 		'vlib/v/tests/string_interpolation_test.v' /* TODO byteptr: &byte.str() behaves differently than byteptr.str() */,
 		'vlib/v/gen/js/tests/js.v', /* local `hello` fn, gets replaced with module `hello` aliased as `hl` */
 		'vlib/v/gen/c/cheaders.v' /* the preprocessor directives are formated to the V standard, even though they are in a string literal */,
+		'examples/c_interop_wkhtmltopdf.v', /* &charptr --> &&char */
+		'examples/path_tracing.v', /* block --> line comments corrupts code */
 	]
 	vfmt_verify_list                = [
 		'cmd/',
+		'examples/',
+		'tutorials/',
 		'vlib/arrays/',
 		'vlib/benchmark/',
 		'vlib/bitfield/',

examples/asm.v

@@ -6,8 +6,8 @@ fn main() {
 		mov eax, a
 		add eax, b
 		mov c, eax
-		; =r (c) // output 
-		; r (a) // input 
+		; =r (c) // output
+		; r (a) // input
 		  r (b)
 	}
 	println('a: $a') // 100

examples/cli.v

@@ -32,9 +32,9 @@ fn main() {
 		description: 'Number of times the message gets printed.'
 	})
 	greet_cmd.add_flag(Flag{
-	 	flag: .string_array
-	 	name: 'fun'
-	 	description: 'Just a dumby flags to show multiple.'
+		flag: .string_array
+		name: 'fun'
+		description: 'Just a dumby flags to show multiple.'
 	})
 	cmd.add_command(greet_cmd)
 	cmd.setup()

examples/compiletime/compile-time-for.v

@@ -1,12 +1,18 @@
 struct App {}
 
 fn (mut app App) method_one() {}
-fn (mut app App) method_two() int {	return 0 }
-fn (mut app App) method_three(s string) string { return s }
+
+fn (mut app App) method_two() int {
+	return 0
+}
+
+fn (mut app App) method_three(s string) string {
+	return s
+}
 
 fn main() {
 	$for method in App.methods {
-		$if method.typ is fn(string) string {
+		$if method.typ is fn (string) string {
 			println('$method.name IS `fn(string) string`')
 		} $else {
 			println('$method.name is NOT `fn(string) string`')
@@ -17,12 +23,12 @@ fn main() {
 			println('$method.name DOES return `int`')
 		}
 		$if method.args[0].typ !is string {
-			println("${method.name}'s first arg is NOT `string`")
+			println("$method.name's first arg is NOT `string`")
 		} $else {
-			println("${method.name}'s first arg IS `string`")
+			println("$method.name's first arg IS `string`")
 		}
 		// TODO: Double inversion, should this even be allowed?
-		$if method.typ is fn() {
+		$if method.typ is fn () {
 			println('$method.name IS a void method')
 		} $else {
 			println('$method.name is NOT a void method')

examples/concurrency/concurrency_http.v

@@ -4,7 +4,7 @@ import time
 
 fn vlang_time(mut wg sync.WaitGroup) ?string {
 	start := time.ticks()
-	data := http.get('https://vlang.io/utc_now')?
+	data := http.get('https://vlang.io/utc_now') ?
 	finish := time.ticks()
 	println('Finish getting time ${finish - start} ms')
 	println(data.text)
@@ -14,7 +14,7 @@ fn vlang_time(mut wg sync.WaitGroup) ?string {
 
 fn remote_ip(mut wg sync.WaitGroup) ?string {
 	start := time.ticks()
-	data := http.get('https://api.ipify.org')?
+	data := http.get('https://api.ipify.org') ?
 	finish := time.ticks()
 	println('Finish getting ip ${finish - start} ms')
 	println(data.text)

examples/database/sqlite.v

@@ -1,7 +1,7 @@
 import sqlite
 
 fn main() {
-	db := sqlite.connect(':memory:')?
+	db := sqlite.connect(':memory:') ?
 	db.exec("create table users (id integer primary key, name text default '');")
 
 	db.exec("insert into users (name) values ('Sam')")
@@ -15,7 +15,7 @@ fn main() {
 	assert name == 'Sam'
 
 	users, code := db.exec('select * from users')
-	println("SQL Result code: $code")
+	println('SQL Result code: $code')
 	for row in users {
 		println(row.vals)
 	}

examples/eventbus/eventbus.v

@@ -2,9 +2,9 @@ module main
 
 import some_module
 
-fn main(){
+fn main() {
 	mut sub := some_module.get_subscriber()
-	sub.subscribe("error", on_error)
+	sub.subscribe('error', on_error)
 	some_module.do_work()
 }
 

examples/eventbus/modules/some_module/some_module.v

@@ -16,19 +16,19 @@ pub:
 	message string
 }
 
-pub fn do_work(){
+pub fn do_work() {
 	work := Work{20}
-	for i in 0..20 {
-		println("working...")
+	for i in 0 .. 20 {
+		println('working...')
 		if i == 15 {
-			error := &MyError{"There was an error."}
-			eb.publish("error", work, error)
-			eb.publish("error", work, error)
+			error := &MyError{'There was an error.'}
+			some_module.eb.publish('error', work, error)
+			some_module.eb.publish('error', work, error)
 			return
 		}
 	}
 }
 
 pub fn get_subscriber() eventbus.Subscriber {
-	return *eb.subscriber
+	return *some_module.eb.subscriber
 }

examples/fibonacci.v

@@ -3,15 +3,15 @@
 
 fn main() {
 	// Check for user input
-//if os.args.len != 2 {
-//		println('usage: fibonacci [rank]')
+	// if os.args.len != 2 {
+	//		println('usage: fibonacci [rank]')
 
-		// Exit
-//		return
-//	}
+	// Exit
+	//		return
+	//	}
 
 	// Parse first argument and cast it to int
-//	stop := os.args[1].int()
+	//	stop := os.args[1].int()
 	stop := 23
 	// Can only calculate correctly until rank 92
 	if stop > 92 {
@@ -23,7 +23,7 @@ fn main() {
 	mut a := 0
 	mut b := 0
 	mut c := 1
-	println(a+c+c)
+	println(a + c + c)
 	for _ in 0 .. stop {
 		// Set a and b to the next term
 		a = b

examples/fireworks/fireworks.v

@@ -61,14 +61,18 @@ fn on_frame(mut app App) {
 
 fn on_event(e &gg.Event, mut app App) {
 	match e.typ {
-		.resized, .resumed { app.resize() }
-		.iconified { app.draw_flag = false }
-		.restored { 
+		.resized, .resumed {
+			app.resize()
+		}
+		.iconified {
+			app.draw_flag = false
+		}
+		.restored {
 			app.draw_flag = true
 			app.resize()
-		} 
+		}
 		else {
-			//println("Type ${e.typ}")
+			// println("Type ${e.typ}")
 		}
 	}
 }
@@ -80,16 +84,17 @@ fn (mut app App) resize() {
 		return
 	}
 	mut s := gg.dpi_scale()
-	
+
 	if s == 0.0 {
 		s = 1.0
-	}	
+	}
 	app.ui.dpi_scale = s
 	app.ui.width = size.width
 	app.ui.height = size.height
 }
 
-[console] // is needed for easier diagnostics on windows
+// is needed for easier diagnostics on windows
+[console]
 fn main() {
 	mut font_path := os.resource_abs_path(os.join_path('../assets/fonts/', 'RobotoMono-Regular.ttf'))
 	$if android {