tools: don't interrupt resolving deps by vpm, when a module failed updating, improve detecting invalid, add update_test (#19867)

Author: ttytm

cmd/tools/vpm/update.v

@@ -26,22 +26,35 @@ fn vpm_update(query []string) {
 	}
 	mut pp := pool.new_pool_processor(callback: update_module)
 	pp.work_on_items(modules)
+	mut errors := 0
 	for res in pp.get_results[ModUpdateInfo]() {
 		if res.has_err {
-			exit(1)
+			errors++
+			continue
 		}
 		resolve_dependencies(get_manifest(res.final_path), modules)
 	}
+	if errors > 0 {
+		exit(1)
+	}
 }
 
 fn update_module(mut pp pool.PoolProcessor, idx int, wid int) &ModUpdateInfo {
 	mut result := &ModUpdateInfo{
 		name: pp.get_item[string](idx)
 	}
 	name := get_name_from_url(result.name) or { result.name }
-	result.final_path = get_path_of_existing_module(result.name) or { return result }
+	result.final_path = get_path_of_existing_module(result.name) or {
+		vpm_error('failed to find path for `${name}`.', verbose: true)
+		result.has_err = true
+		return result
+	}
 	println('Updating module `${name}` in `${fmt_mod_path(result.final_path)}` ...')
-	vcs := vcs_used_in_dir(result.final_path) or { return result }
+	vcs := vcs_used_in_dir(result.final_path) or {
+		vpm_error('failed to find version control system for `${name}`.', verbose: true)
+		result.has_err = true
+		return result
+	}
 	vcs.is_executable() or {
 		result.has_err = true
 		vpm_error(err.msg())

cmd/tools/vpm/update_test.v

@@ -0,0 +1,48 @@
+// vtest flaky: true
+// vtest retry: 3
+import os
+
+const (
+	v         = os.quoted_path(@VEXE)
+	test_path = os.join_path(os.vtmp_dir(), 'vpm_update_test')
+)
+
+fn testsuite_begin() {
+	os.setenv('VMODULES', test_path, true)
+	os.setenv('VPM_DEBUG', '', true)
+	os.setenv('VPM_NO_INCREMENT', '1', true)
+}
+
+fn testsuite_end() {
+	os.rmdir_all(test_path) or {}
+}
+
+// Tests if `v update` detects installed modules and runs successfully.
+fn test_update() {
+	os.execute_or_exit('${v} install pcre')
+	os.execute_or_exit('${v} install nedpals.args')
+	os.execute_or_exit('${v} install https://github.com/spytheman/vtray')
+	res := os.execute_opt('${v} update') or { panic(err) }
+	assert res.output.contains('Updating module `pcre`'), res.output
+	assert res.output.contains('Updating module `nedpals.args`'), res.output
+	assert res.output.contains('Updating module `vtray`'), res.output
+	assert res.output.contains('Skipping download count increment for `nedpals.args`.'), res.output
+	assert res.output.contains('Skipping download count increment for `pcre`.'), res.output
+}
+
+fn test_update_idents() {
+	mut res := os.execute_or_exit('${v} update pcre')
+	assert res.output.contains('Updating module `pcre`'), res.output
+	res = os.execute_or_exit('${v} update nedpals.args vtray')
+	assert res.output.contains('Updating module `vtray`'), res.output
+	assert res.output.contains('Updating module `nedpals.args`'), res.output
+	// Try update not installed.
+	res = os.execute('${v} update vsl')
+	assert res.exit_code == 1
+	assert res.output.contains('failed to find `vsl`'), res.output
+	// Try update mixed.
+	res = os.execute('${v} update pcre vsl')
+	assert res.exit_code == 1
+	assert res.output.contains('Updating module `pcre`'), res.output
+	assert res.output.contains('failed to find `vsl`'), res.output
+}