cgen,v.builder: cleanup const generation/checks; fix cross compilation of .dll files from linux->windows (#23971)

Author: spytheman

vlib/v/builder/cc.v

@@ -1125,11 +1125,20 @@ fn (mut c Builder) cc_windows_cross() {
 	// add the thirdparty .o files, produced by all the #flag directives:
 	args << cflags.c_options_only_object_files()
 	args << os.quoted_path(c.out_name_c)
+
+	mut c_options_after_target := []string{}
 	if c.pref.ccompiler == 'msvc' {
-		args << cflags.c_options_after_target_msvc()
+		c_options_after_target << cflags.c_options_after_target_msvc()
 	} else {
-		args << cflags.c_options_after_target()
+		c_options_after_target << cflags.c_options_after_target()
+	}
+	for lf in c.ccoptions.linker_flags {
+		if lf in c_options_after_target {
+			continue
+		}
+		c_options_after_target << lf
 	}
+	args << c_options_after_target
 
 	if current_os !in ['macos', 'linux', 'termux'] {
 		println(current_os)
@@ -1145,9 +1154,7 @@ fn (mut c Builder) cc_windows_cross() {
 
 	all_args << args
 	all_args << c.get_subsystem_flag()
-	// Note: c.ccoptions.linker_flags was already in cflags.c_options_after_target(), which is in args, so no need to add it again here
 	all_args << c.pref.ldflags
-
 	c.dump_c_options(all_args)
 	mut cmd := cross_compiler_name_path + ' ' + all_args.join(' ')
 	// cmd := 'clang -o $obj_name -w $include -m32 -c -target x86_64-win32 ${pref.default_module_path}/$c.out_name_c'

vlib/v/gen/c/consts_and_globals.v

@@ -36,9 +36,8 @@ fn (mut g Gen) const_decl(node ast.ConstDecl) {
 		mut const_name := '_const_' + name
 		if g.pref.translated && !g.is_builtin_mod
 			&& !util.module_is_builtin(field.name.all_before_last('.')) {
-			mut x := util.no_dots(field.name)
-			if x.starts_with('main__') {
-				const_name = x['main__'.len..]
+			if name.starts_with('main__') {
+				const_name = name.all_after_first('main__')
 			}
 		}
 		if !g.is_builtin_mod {
@@ -55,7 +54,8 @@ fn (mut g Gen) const_decl(node ast.ConstDecl) {
 					&& (!g.is_cc_msvc || field.expr.elem_type != ast.string_type) && elems_are_const {
 					styp := g.styp(field.expr.typ)
 					val := g.expr_string(field.expr)
-					g.global_const_defs[util.no_dots(field.name)] = GlobalConstDef{
+					// eprintln('> const_name: ${const_name} | name: ${name} | styp: ${styp} | val: ${val}')
+					g.global_const_defs[name] = GlobalConstDef{
 						mod:       field.mod
 						def:       '${g.static_non_parallel}${styp} ${const_name} = ${val}; // fixed array const'
 						dep_names: g.table.dependent_names_in_expr(field_expr)
@@ -72,7 +72,7 @@ fn (mut g Gen) const_decl(node ast.ConstDecl) {
 			ast.StringLiteral {
 				val := g.expr_string(field.expr)
 				typ := if field.expr.language == .c { 'char*' } else { 'string' }
-				g.global_const_defs[util.no_dots(field.name)] = GlobalConstDef{
+				g.global_const_defs[name] = GlobalConstDef{
 					mod:   field.mod
 					def:   '${typ} ${const_name}; // a string literal, inited later'
 					init:  '\t${const_name} = ${val};'
@@ -121,7 +121,7 @@ fn (mut g Gen) const_decl(node ast.ConstDecl) {
 						if field.expr.expr.is_fixed && g.pref.build_mode != .build_module {
 							styp := g.styp(field.expr.typ)
 							val := g.expr_string(field.expr.expr)
-							g.global_const_defs[util.no_dots(field.name)] = GlobalConstDef{
+							g.global_const_defs[name] = GlobalConstDef{
 								mod:       field.mod
 								def:       '${g.static_non_parallel}${styp} ${const_name} = ${val}; // fixed array const'
 								dep_names: g.table.dependent_names_in_expr(field_expr)
@@ -435,6 +435,7 @@ fn (mut g Gen) global_decl(node ast.GlobalDecl) {
 		attributes += '__attribute__ ((section ("${attr.arg}"))) '
 	}
 	for field in node.fields {
+		name := c_name(field.name)
 		if g.pref.skip_unused {
 			if field.name !in g.table.used_features.used_globals {
 				$if trace_skip_unused_globals ? {
@@ -462,7 +463,7 @@ fn (mut g Gen) global_decl(node ast.GlobalDecl) {
 		def_builder.write_string('${extern}${visibility_kw}${modifier}${styp} ${attributes}${field.name}')
 		if cextern {
 			def_builder.writeln('; // global 2')
-			g.global_const_defs[util.no_dots(field.name)] = GlobalConstDef{
+			g.global_const_defs[name] = GlobalConstDef{
 				mod:   node.mod
 				def:   def_builder.str()
 				order: -1
@@ -515,7 +516,7 @@ fn (mut g Gen) global_decl(node ast.GlobalDecl) {
 			}
 		}
 		def_builder.writeln('; // global 6')
-		g.global_const_defs[util.no_dots(field.name)] = GlobalConstDef{
+		g.global_const_defs[name] = GlobalConstDef{
 			mod:       node.mod
 			def:       def_builder.str()
 			init:      init