checker: fix negative cap, len checks in array init (#19694)

vlang · Oct 29, 2023 · aa28efc · aa28efc
1 parent 1e578b1
commit aa28efc
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/vlib/v/checker/containers.v b/vlib/v/checker/containers.v
@@ -338,6 +338,12 @@ fn (mut c Checker) check_array_init_para_type(para string, mut expr ast.Expr, po
 	if sym.kind !in [.int, .int_literal] {
 		c.error('array ${para} needs to be an int', pos)
 	}
+	if expr is ast.IntegerLiteral {
+		lit := expr as ast.IntegerLiteral
+		if lit.val.int() < 0 {
+			c.error('array ${para} can not be negative', lit.pos)
+		}
+	}
 }
 
 fn (mut c Checker) ensure_sumtype_array_has_default_value(node ast.ArrayInit) {

diff --git a/vlib/v/checker/tests/array_init_with_len_cap_err.out b/vlib/v/checker/tests/array_init_with_len_cap_err.out
@@ -0,0 +1,8 @@
+vlib/v/checker/tests/array_init_with_len_cap_err.vv:1:16: error: array len can not be negative
+    1 | _ = []int{len: -1}
+      |                ~~
+    2 | _ = []int{cap: -1}
+vlib/v/checker/tests/array_init_with_len_cap_err.vv:2:16: error: array cap can not be negative
+    1 | _ = []int{len: -1}
+    2 | _ = []int{cap: -1}
+      |                ~~
diff --git a/vlib/v/checker/tests/array_init_with_len_cap_err.vv b/vlib/v/checker/tests/array_init_with_len_cap_err.vv
@@ -0,0 +1,2 @@
+_ = []int{len: -1}
+_ = []int{cap: -1}