checker: check or-block used on non-option value (#17444)

Author: felipensp

vlib/v/checker/checker.v

@@ -3134,8 +3134,12 @@ fn (mut c Checker) ident(mut node ast.Ident) ast.Type {
 		info := node.info as ast.IdentVar
 		// Got a var with type T, return current generic type
 		if node.or_expr.kind != .absent {
-			if !info.typ.has_flag(.option) && node.or_expr.kind == .propagate_option {
-				c.error('cannot use `?` on non-option variable', node.pos)
+			if !info.typ.has_flag(.option) {
+				if node.or_expr.kind == .propagate_option {
+					c.error('cannot use `?` on non-option variable', node.pos)
+				} else if node.or_expr.kind == .block {
+					c.error('cannot use `or {}` block on non-option variable', node.pos)
+				}
 			}
 			unwrapped_typ := info.typ.clear_flag(.option).clear_flag(.result)
 			c.expected_or_type = unwrapped_typ
@@ -3228,8 +3232,13 @@ fn (mut c Checker) ident(mut node ast.Ident) ast.Type {
 						if node.or_expr.kind == .absent {
 							return typ.clear_flag(.result)
 						}
-						if !typ.has_flag(.option) && node.or_expr.kind == .propagate_option {
-							c.error('cannot use `?` on non-option variable', node.pos)
+						if !typ.has_flag(.option) {
+							if node.or_expr.kind == .propagate_option {
+								c.error('cannot use `?` on non-option variable', node.pos)
+							} else if node.or_expr.kind == .block {
+								c.error('cannot use `or {}` block on non-option variable',
+									node.pos)
+							}
 						}
 						unwrapped_typ := typ.clear_flag(.option).clear_flag(.result)
 						c.expected_or_type = unwrapped_typ

vlib/v/checker/tests/or_block_non_option_err.out

@@ -0,0 +1,7 @@
+vlib/v/checker/tests/or_block_non_option_err.vv:3:5: error: cannot use `or {}` block on non-option variable
+    1 | name := 100
+    2 | 
+    3 | _ = name or {
+      |     ~~~~
+    4 |     100
+    5 | }

vlib/v/checker/tests/or_block_non_option_err.vv

@@ -0,0 +1,5 @@
+name := 100
+
+_ = name or {
+	100
+}