parser: check for using comptime $veb.html()/$vweb.html(), without importing veb or vweb (#21957)

Author: yuyi98

examples/vweb/veb_example.v

@@ -46,11 +46,11 @@ pub fn (mut app App) index(mut ctx Context) veb.Result {
 	show := true
 	hello := 'Hello world from veb, request number: ${c}'
 	numbers := [1, 2, 3]
-	return $vweb.html()
+	return $veb.html()
 }
 
 pub fn (mut app App) custom_template(mut ctx Context) veb.Result {
-	return $vweb.html('custom.html')
+	return $veb.html('custom.html')
 }
 
 pub fn (mut app App) show_text(mut ctx Context) veb.Result {

vlib/v/ast/ast.v

@@ -1938,6 +1938,7 @@ pub:
 	method_pos       token.Pos
 	scope            &Scope = unsafe { nil }
 	is_vweb          bool
+	is_veb           bool
 	is_embed         bool // $embed_file(...)
 	is_env           bool // $env(...) // TODO: deprecate after $d() is stable
 	is_compile_value bool // $d(...)

vlib/v/fmt/fmt.v

@@ -2153,11 +2153,19 @@ pub fn (mut f Fmt) comptime_call(node ast.ComptimeCall) {
 	if node.is_vweb {
 		if node.method_name == 'html' {
 			if node.args.len == 1 && node.args[0].expr is ast.StringLiteral {
-				f.write('\$vweb.html(')
+				if node.is_veb {
+					f.write('\$veb.html(')
+				} else {
+					f.write('\$vweb.html(')
+				}
 				f.expr(node.args[0].expr)
 				f.write(')')
 			} else {
-				f.write('\$vweb.html()')
+				if node.is_veb {
+					f.write('\$veb.html()')
+				} else {
+					f.write('\$vweb.html()')
+				}
 			}
 		} else {
 			f.write('\$tmpl(')

vlib/v/parser/comptime.v

@@ -106,13 +106,25 @@ fn (mut p Parser) comptime_call() ast.ComptimeCall {
 	}
 	start_pos := p.tok.pos()
 	p.check(.dollar)
+	mut is_veb := false
 	error_msg := 'only `\$tmpl()`, `\$env()`, `\$embed_file()`, `\$pkgconfig()`, `\$vweb.html()`, `\$compile_error()`, `\$compile_warn()`, `\$d()` and `\$res()` comptime functions are supported right now'
 	if p.peek_tok.kind == .dot {
 		name := p.check_name() // skip `vweb.html()` TODO
 		if name != 'vweb' && name != 'veb' {
 			p.error(error_msg)
 			return err_node
 		}
+		import_mods := p.ast_imports.map(it.mod)
+		if name == 'vweb' && 'vweb' !in import_mods && 'x.vweb' !in import_mods {
+			p.error_with_pos('`\$vweb` cannot be used without importing vweb', start_pos.extend(p.prev_tok.pos()))
+			return err_node
+		} else if name == 'veb' {
+			if 'veb' !in import_mods {
+				p.error_with_pos('`\$veb` cannot be used without importing veb', start_pos.extend(p.prev_tok.pos()))
+				return err_node
+			}
+			is_veb = true
+		}
 		p.check(.dot)
 	}
 	method_name := p.check_name()
@@ -265,6 +277,7 @@ fn (mut p Parser) comptime_call() ast.ComptimeCall {
 				return ast.ComptimeCall{
 					scope: unsafe { nil }
 					is_vweb: true
+					is_veb: is_veb
 					method_name: method_name
 					args_var: literal_string_param
 					args: [arg]
@@ -306,6 +319,7 @@ fn (mut p Parser) comptime_call() ast.ComptimeCall {
 	return ast.ComptimeCall{
 		scope: unsafe { nil }
 		is_vweb: true
+		is_veb: is_veb
 		vweb_tmpl: file
 		method_name: method_name
 		args_var: literal_string_param

vlib/v/parser/tests/comptime_veb_without_import_veb_err.out

@@ -0,0 +1,5 @@
+vlib/v/parser/tests/comptime_veb_without_import_veb_err.vv:2:2: error: `$veb` cannot be used without importing veb
+    1 | fn main() {
+    2 |     $veb.html('index.html')
+      |     ~~~~
+    3 | }

vlib/v/parser/tests/comptime_veb_without_import_veb_err.vv

@@ -0,0 +1,3 @@
+fn main() {
+	$veb.html('index.html')
+}

vlib/v/parser/tests/comptime_vweb_without_import_vweb_err.out

@@ -0,0 +1,5 @@
+vlib/v/parser/tests/comptime_vweb_without_import_vweb_err.vv:2:2: error: `$vweb` cannot be used without importing vweb
+    1 | fn main() {
+    2 |     $vweb.html('index.html')
+      |     ~~~~~
+    3 | }

vlib/v/parser/tests/comptime_vweb_without_import_vweb_err.vv

@@ -0,0 +1,3 @@
+fn main() {
+	$vweb.html('index.html')
+}