Skip to content

Commit dafca93

Browse files
authored
tests: use value and the .len field, for the left/right values, shown in failing assertions (#22393)
1 parent 2b546c4 commit dafca93

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

vlib/v/preludes/test_runner_normal.v

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,10 @@ fn (mut runner NormalTestRunner) assert_fail(i &VAssertMetaInfo) {
131131
}
132132
eprintln('${final_filepath} ${final_funcname}')
133133
if i.op.len > 0 && i.op != 'call' {
134-
mut lvtitle := ' Left value:'
135-
mut rvtitle := ' Right value:'
136-
mut slvalue := '${i.lvalue}'
137-
mut srvalue := '${i.rvalue}'
134+
mut lvtitle := ' Left value (len: ${i.lvalue.len}):'
135+
mut rvtitle := ' Right value (len: ${i.rvalue.len}):'
136+
mut slvalue := '`${i.lvalue}`'
137+
mut srvalue := '`${i.rvalue}`'
138138
// Do not print duplicate values to avoid confusion. In mosts tests the developer does
139139
// `assert foo() == [1, 2, 3]`
140140
// There's no need to print "[1, 2, 3]" again (left: [1,2,3,4] right:[1,2,3])
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
vlib/v/tests/skip_unused/assert_with_extra_message_works_test.vv:7: fn test_interpolation_with_assert_that_has_extra_message
22
> assert 'abc$i' != 'abc77', my_failure_message(i)
3-
Left value: abc77
4-
Right value: abc77
3+
Left value (len: 5): `abc77`
4+
Right value (len: 5): `abc77`
55
Message: the assert failed :-|, i: 77
66

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
vlib/v/tests/skip_unused/assert_with_extra_message_works_test.vv:7: fn test_interpolation_with_assert_that_has_extra_message
22
> assert 'abc$i' != 'abc77', my_failure_message(i)
3-
Left value: abc77
4-
Right value: abc77
3+
Left value (len: 5): `abc77`
4+
Right value (len: 5): `abc77`
55
Message: the assert failed :-|, i: 77
66

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
vlib/v/tests/skip_unused/assert_works_test.vv:2: fn test_abc
22
> assert 'abc' == 'xyz'
3-
Left value: abc
4-
Right value: xyz
3+
Left value (len: 3): `abc`
4+
Right value (len: 3): `xyz`
55

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
vlib/v/tests/skip_unused/assert_works_test.vv:2: fn test_abc
22
> assert 'abc' == 'xyz'
3-
Left value: abc
4-
Right value: xyz
3+
Left value (len: 3): `abc`
4+
Right value (len: 3): `xyz`
55

0 commit comments

Comments
 (0)