vlib: make ./v -Wimpure-v -W test vlib/ pass on Linux (#21554)

Author: spytheman

vlib/compress/zstd/zstd.v renamed to vlib/compress/zstd/zstd.c.v

@@ -46,6 +46,6 @@ fn test_crypto_sha256_224() {
 	// with checksum
 	digest.reset()
 	_ := digest.write(data)!
-	chksum := digest.checksum()
+	chksum := digest.sum([])
 	assert chksum.hex() == expected
 }

vlib/crypto/sha256/sha256_test.v

@@ -45,7 +45,7 @@ fn test_crypto_sha512_384() {
 
 	d.reset()
 	d.write(data) or { assert false }
-	chksum := d.checksum()
+	chksum := d.sum([])
 	assert chksum.hex() == expected
 }
 
@@ -62,7 +62,7 @@ fn test_crypto_sha512_224() {
 
 	d.reset()
 	d.write(data) or { assert false }
-	chksum := d.checksum()
+	chksum := d.sum([])
 	assert chksum.hex() == expected
 }
 
@@ -79,6 +79,6 @@ fn test_crypto_sha512_256() {
 
 	d.reset()
 	d.write(data) or { assert false }
-	chksum := d.checksum()
+	chksum := d.sum([])
 	assert chksum.hex() == expected
 }

vlib/crypto/sha512/sha512_test.v

@@ -36,6 +36,11 @@ struct TestDefaultAttribute {
 }
 
 fn test_mysql_orm() {
+	$if !network ? {
+		eprintln('> Skipping test ${@FN}, since `-d network` is not passed.')
+		eprintln('> This test requires a working mysql server running on localhost.')
+		return
+	}
 	mut db := mysql.connect(
 		host: '127.0.0.1'
 		port: 3306

vlib/db/mysql/mysql_orm_test.v

@@ -1,6 +1,11 @@
 import db.mysql
 
 fn test_mysql() {
+	$if !network ? {
+		eprintln('> Skipping test ${@FN}, since `-d network` is not passed.')
+		eprintln('> This test requires a working mysql server running on localhost.')
+		return
+	}
 	config := mysql.Config{
 		host: '127.0.0.1'
 		port: 3306

vlib/db/mysql/mysql_test.v

@@ -1,6 +1,11 @@
 import db.mysql
 
 fn test_prep() {
+	$if !network ? {
+		eprintln('> Skipping test ${@FN}, since `-d network` is not passed.')
+		eprintln('> This test requires a working mysql server running on localhost.')
+		return
+	}
 	config := mysql.Config{
 		host: '127.0.0.1'
 		port: 3306

vlib/db/mysql/prepared_stmt_test.v

@@ -10,6 +10,11 @@ struct Demo {
 }
 
 fn test_float_field() {
+	$if !network ? {
+		eprintln('> Skipping test ${@FN}, since `-d network` is not passed.')
+		eprintln('> This test requires a working postgres server running on localhost.')
+		return
+	}
 	conn := 'host=localhost user=test password=test' // insert own connection string
 	db := pg.connect_with_conninfo(conn)!
 	defer {

vlib/db/pg/pg_double_test.v

@@ -36,6 +36,11 @@ struct TestDefaultAttribute {
 }
 
 fn test_pg_orm() {
+	$if !network ? {
+		eprintln('> Skipping test ${@FN}, since `-d network` is not passed.')
+		eprintln('> This test requires a working postgres server running on localhost.')
+		return
+	}
 	mut db := pg.connect(
 		host: 'localhost'
 		user: 'postgres'
@@ -51,7 +56,7 @@ fn test_pg_orm() {
 		orm.TableField{
 			name: 'id'
 			typ: typeof[string]().idx
-			is_time: false
+			//			is_time: false
 			default_val: ''
 			is_arr: false
 			attrs: [
@@ -72,15 +77,15 @@ fn test_pg_orm() {
 		orm.TableField{
 			name: 'name'
 			typ: typeof[string]().idx
-			is_time: false
+			//			is_time: false
 			default_val: ''
 			is_arr: false
 			attrs: []
 		},
 		orm.TableField{
 			name: 'age'
 			typ: typeof[i64]().idx
-			is_time: false
+			//			is_time: false
 			default_val: ''
 			is_arr: false
 			attrs: []
@@ -152,7 +157,8 @@ fn test_pg_orm() {
 	information_schema_custom_sql := ['integer', 'text', 'character varying',
 		'timestamp without time zone', 'uuid']
 	for data_type in result_custom_sql {
-		information_schema_data_types_results << data_type.vals[0]
+		x := data_type.vals[0]!
+		information_schema_data_types_results << x?
 	}
 
 	sql db {
@@ -217,7 +223,8 @@ fn test_pg_orm() {
 	mut information_schema_defaults_results := []string{}
 
 	for defaults in result_defaults {
-		information_schema_defaults_results << defaults.vals[0]
+		x := defaults.vals[0]!
+		information_schema_defaults_results << x?
 	}
 	sql db {
 		drop table TestDefaultAttribute

vlib/db/pg/pg_orm_test.v

@@ -2,21 +2,27 @@ module main
 
 import db.pg
 
-const query = 'SELECT ischema.table_schema, c.relname, a.attname, t.typname, t.typalign, t.typlen
-  FROM pg_class c
-  JOIN information_schema.tables ischema on ischema.table_name = c.relname
-  JOIN pg_attribute a ON (a.attrelid = c.oid)
-  JOIN pg_type t ON (t.oid = a.atttypid)
-WHERE
-  a.attnum >= 0'
-
 fn test_large_exec() {
+	$if !network ? {
+		eprintln('> Skipping test ${@FN}, since `-d network` is not passed.')
+		eprintln('> This test requires a working postgres server running on localhost.')
+		return
+	}
+
 	db := pg.connect(pg.Config{ user: 'postgres', password: 'secret', dbname: 'postgres' })!
 	defer {
 		db.close()
 	}
 
-	rows := db.exec(query)!
+	rows := db.exec('
+SELECT ischema.table_schema, c.relname, a.attname, t.typname, t.typalign, t.typlen
+  FROM pg_class c
+  JOIN information_schema.tables ischema on ischema.table_name = c.relname
+  JOIN pg_attribute a ON (a.attrelid = c.oid)
+  JOIN pg_type t ON (t.oid = a.atttypid)
+WHERE
+  a.attnum >= 0
+ ')!
 	for row in rows {
 		// We just need to access the memory to ensure it's properly allocated
 		row.str()

vlib/db/pg/pg_test.v

@@ -112,8 +112,6 @@ fn (mut handler MyHttpHandler) handle(req http.Request) http.Response {
 	return r
 }
 
-const cport = 18197
-
 fn test_server_custom_handler() {
 	log.warn('${@FN} started')
 	defer {
@@ -123,7 +121,7 @@ fn test_server_custom_handler() {
 	mut server := &http.Server{
 		accept_timeout: atimeout
 		handler: handler
-		port: cport
+		addr: ':18197'
 	}
 	t := spawn server.listen_and_serve()
 	server.wait_till_running()!