Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle header continuation fields #10930

Closed
mcastorina opened this issue Jul 23, 2021 · 2 comments · Fixed by #10936
Closed

Handle header continuation fields #10930

mcastorina opened this issue Jul 23, 2021 · 2 comments · Fixed by #10936
Assignees
@mcastorina
Labels
Feature Request This issue is made to request a feature. Unit: vlib Bugs/feature requests, that are related to the vlib.

Comments

@mcastorina
Copy link
Contributor

#10922 (comment)
@mcastorina mcastorina added the Feature Request This issue is made to request a feature. label Jul 23, 2021
@mcastorina mcastorina self-assigned this Jul 23, 2021
@mcastorina mcastorina mentioned this issue Jul 23, 2021
Merged
@mcastorina mcastorina added the Unit: vlib Bugs/feature requests, that are related to the vlib. label Jul 23, 2021
@mcastorina
Copy link
Contributor Author

@JalonSolov if I understand correctly, if we receive the following..

HTTP/1.1 200 OK
Header1: foo
     bar
Header1: baz

bazz

The header should be:

'Header1': ['foo bar', 'baz']

Is that right?

@JalonSolov
Copy link
Contributor

Correct. The line that starts with whitespace is a continuation of the line above, and should be joined to it with a single space separator.

mcastorina added a commit to mcastorina/v that referenced this issue Jul 23, 2021
@mcastorina
net: add parse_headers function and handle header line folding
060ba37 
Closes vlang#10930
@mcastorina mcastorina mentioned this issue Jul 23, 2021
Merged
spytheman pushed a commit that referenced this issue Jul 24, 2021
@mcastorina
net: add parse_headers function and handle header line folding (#10936)
0acb84d 
Closes #10930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcastorina mcastorina

Labels
Feature Request This issue is made to request a feature. Unit: vlib Bugs/feature requests, that are related to the vlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net: add parse_headers function and handle header line folding mcastorina/v
2 participants
@mcastorina @JalonSolov