Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update deployment workflow #21323

Merged
merged 2 commits into from
Apr 21, 2024
Merged

ci: update deployment workflow #21323

merged 2 commits into from
Apr 21, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 20, 2024

Sorry about the recent oopsi with the deployment workflow. Using the commit message from environment variables that were not added to the github environment in a separate step caused missing information in the commit messages.

With this PR I want to take the chance to fix it properly and also further improve the workflow.

  • The changes allow to correctly test vc generation on forks and PRs and deploy on vlang/v master.
  • Adds a concurrency setting so interference in deployment will be prevented and ensure sure the latest state will be pushed in such edge cases
  • For better traceability it prints the log after creating the commit and rebasing

Example run: https://github.com/ttytm/v/actions/runs/8767565529/job/24060957263

The same applies for module doc generating workflow, though the last list point is excluded here since it's not necessary.

@spytheman spytheman merged commit d775837 into vlang:master Apr 21, 2024
9 checks passed
@ttytm ttytm deleted the ci/update-deploy branch April 22, 2024 08:13
@ttytm
Copy link
Member Author

ttytm commented Apr 23, 2024

This still can be improved. Sometimes it's hard to coordinate changes step by step.
Would make a refinement part of one of the follow-ups there would be one where it fits well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants