Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: skip file that is not compatible with sanitized=undefined tests during v test-self #21330

Closed
wants to merge 1 commit into from

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 21, 2024

./v -cc clang -cflags -fsanitize=undefined -o v2 cmd/v && ./v2 -cc clang -cflags -fsanitize=undefined vlib/v/compiler_errors_test.v

@spytheman
Copy link
Member

Why is this skip needed?

Afaik it works, and can reveal real problems - most of the .vv files, are tested by compiler_errors_test.v .

@spytheman
Copy link
Member

spytheman commented Apr 21, 2024

#21331 should fix the root cause (cgen for .sort(), called on an empty array).

With it:
image

@spytheman spytheman closed this Apr 21, 2024
@ttytm
Copy link
Member Author

ttytm commented Apr 22, 2024

Yep that's the better solution.

@ttytm ttytm deleted the tools/vtest-skip-undefined branch April 22, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants