Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update binary_artifact.yml #21364

Merged
merged 8 commits into from
Apr 28, 2024
Merged

ci: update binary_artifact.yml #21364

merged 8 commits into from
Apr 28, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 27, 2024 •
edited
Loading

  • Adds tiggers to include PRs updating this workflow, while the publishing and releasing part is limited to tag pushes.
  • Simplifes the current state without compromising on functionality where it can be appropriate, makes more consistent.
  • For macos-x86 macos-13 was set instead of macos-latest because macos-latest is migrating towards arm runners.

The workflow run under this PR should allow to manually inspect the crated binary artifacts.
edit: https://github.com/vlang/v/actions/runs/8860588557?pr=21364

spytheman
spytheman approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. It is now simpler and cleaner.

@spytheman
Copy link
Member

Can you please also add:
find |grep pdb$|xargs rm -rf
find |grep ilk$|xargs rm -rf
to the windows rm script?

image

It will reduce the size of the windows .zip file.

@ttytm
Copy link
Member Author

ttytm commented Apr 28, 2024

Good observation. Done 👍

@spytheman spytheman merged commit 53c941e into vlang:master Apr 28, 2024
11 checks passed
@spytheman
Copy link
Member

Thank you 🙇🏻‍♂️ .

@ttytm ttytm deleted the ci/bin-artifcat branch April 28, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttytm @spytheman