Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update check_os_api_parity.v #21367

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 27, 2024

The PR does required maintenance work on the check_os_api_parity tool.

@spytheman spytheman merged commit 3117126 into vlang:master Apr 28, 2024
51 checks passed
@ttytm
Copy link
Member Author

ttytm commented Apr 28, 2024

Thanks for the reviewing work!

I had a tiny mistake in there, I didn't manged to push:

- summary := 'Different APIs found for module: `${m}`, between OS base: `${base_os}` and OS: `${api_os}`'
+ summary := 'Different APIs found for module: `${m}`, between OS base: `${base_os}` and OS: `${oname}`'

Should be oname in the print.Should be oname in the print.
You can update locally and check the output when running the tool.

@ttytm ttytm deleted the tools/check-os-api-parity branch April 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants