Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure master is available when trying to check out it's commits to build oldv #21414

Merged
merged 1 commit into from
May 4, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented May 4, 2024

Fixes workflow fails of the Bootstrapping CI on forks and occasionally in PRs.

Failures happen, because oldv receives a commit that is available on master, but the master branch itself is not available in the workflow due to a shallow checkout of the checkout action.

The fix is simple by ensuring the master branch is available.

@@ -40,7 +40,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 10
fetch-depth: 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 to fetch other branches. Ref. https://github.com/actions/checkout

@ttytm
Copy link
Member Author

ttytm commented May 4, 2024

@medvednikov medvednikov merged commit 206441c into vlang:master May 4, 2024
7 checks passed
@ttytm ttytm deleted the ci/bt-vup branch May 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants