v.util: fix the performance of v test-cleancode, when a slower diff tool is installed
#21447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ool is installed
spytheman
changed the title
v test-cleancode, when a slower diff tool is installedv test-cleancode, when a slower diff tool is installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a constant meant that the diff tools were always found, even if they were not used.
That added some milliseconds, to the start time of programs that used
v.util.diff, likev fmtorv test-cleancode.Changing
available_toolto be a function, allows it to delay, and cache the invocation of the slower find_working_diff_tool, until it is actually needed (which may be never).