cgen: support inc cond for c style for loop with alias types #21708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath { sin, cos }`"
This reverts commit ddf0468.
spytheman
reviewed
Jun 21, 2024
spytheman
reviewed
Jun 21, 2024
Comment on lines
-523
to
+525
| g.write(';') | ||
| if !g.inside_for_c_stmt { | ||
| g.write(';') | ||
| } |
There was a problem hiding this comment.
That is short, but does not seem the right place for the fix.
Why does the non aliased case work, without such check?
There was a problem hiding this comment.
It is because the assignment operator overloading here assumes to be a statement ending with the ; but in a for c loop it is not the case. I also can't find a better place to make it work because it returns after code generation.
I tried removing the return and adding the g.write(';') but the compiler failed.
raw-bin
pushed a commit
to raw-bin/v
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21707