Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: improve checks for embed in anon struct #21877

Merged
merged 8 commits into from
Jul 21, 2024
Merged

checker: improve checks for embed in anon struct #21877

merged 8 commits into from
Jul 21, 2024

Conversation

Delta456
Copy link
Member

Fixes #21876

Delta456
Delta456 commented Jul 15, 2024
View reviewed changes
vlib/v/parser/struct.v Outdated Show resolved Hide resolved
@Delta456 Delta456 changed the title parser, checker: improve checks for embed in anon struct checker: improve checks for embed in anon struct Jul 16, 2024
@Delta456 Delta456 marked this pull request as ready for review July 16, 2024 12:24
spytheman
spytheman reviewed Jul 17, 2024
View reviewed changes
vlib/v/checker/checker.v Outdated Show resolved Hide resolved
@Delta456 Delta456 marked this pull request as draft July 20, 2024 07:01
@Delta456
Copy link
Member Author

Delta456 commented Jul 20, 2024 •
edited
Loading

I have converted this PR into a draft and would require help.

EDIT: Issue resolved

@Delta456 Delta456 marked this pull request as ready for review July 20, 2024 09:02
spytheman
spytheman approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit b3b6ce5 into vlang:master Jul 21, 2024
73 checks passed
@Delta456 Delta456 mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medvednikov medvednikov medvednikov left review comments

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

anonymous struct embedding lacks checks
3 participants
@Delta456 @spytheman @medvednikov