Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: fix global fixed array key resolution when it is a constant ident #21900

Merged
merged 3 commits into from
Jul 20, 2024
Merged

checker: fix global fixed array key resolution when it is a constant ident #21900

merged 3 commits into from
Jul 20, 2024

Conversation

felipensp
Copy link
Member

Fix #21762

@felipensp felipensp changed the title checker: fix global fixed array resolution checker: fix global fixed array key resolution when it is a constant ident Jul 20, 2024
@felipensp felipensp marked this pull request as ready for review July 20, 2024 17:51
spytheman
spytheman approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 8a0fc25 into vlang:master Jul 20, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation failure for global array when array size is a const in another module
2 participants
@felipensp @spytheman