-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checker: apply stricter type checks to function args and return types #5155
Conversation
@UweKrueger I think we should make |
@medvednikov: I've changed the interface of |
@UweKrueger there was a big discussion on Discord (#gamedev), and it was decided that it's best to use f32 in I was wrong, sorry :) |
I'll be introducing |
Actually, I already felt uneasy when I implemented that, since f32 is used everywhere in I've reverted the relevant commit. |
Agreed, but
|
Yes, exactly :) Thanks |
@UweKrueger I think this should be allowed, since f32 > int |
@medvednikov yes, even though there might be a loss in precision, this kind of automatic promotion makes life easier, especially when using |
This PR makes type checks more consistent by introducing the same type checks for function arguments and function return types that have been introduced for other cases in PR #4971.