rand: Reorganize random: Phase 2 #5289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…precated functions
hungrybluedev
commented
Jun 10, 2020
| @@ -18,8 +18,7 @@ fn htonl64(payload_len u64) byteptr { | |||
| } | |||
|
|
|||
| fn create_masking_key() []byte { | |||
| mut rnd := pcg32.PCG32RNG{} | |||
| mask_bit := byte(rnd.int()) | |||
| mask_bit := byte(rand.intn(255)) | |||
There was a problem hiding this comment.
rand.intn(max) is exclusive of max. So it should be rand.intn(256). But honestly it doesn't make a practical difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2 out of 3: Adding global functions and clean-up
This three phase project is a reorganization of the
randmodule currently present invlib.The second phase is a clean-up of the
randmodule. It aims to bring global, top-level functions to reduce the friction for usage for casual users. The ability to choose a generator remains mostly intact. The only change is that the generators will move to their respective modules.What changes does it bring?
util.vto theutilmodule. It contains frequently used constants and helper functions to create time-based seed arrays and values.rand_f32(max),rand_f64(max), etc. that depend onC.RAND_MAX.What it does not bring? (i.e. TODO)
Remaining for phase 3
shuffle.perm, etc.truewith a probability ofpin [0.0, 1.0), and other functions. (Suggestions welcome in the Discord server in the#v-developmentchannel)