Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: poisoning #7236

Closed
wants to merge 3 commits into from
Closed

PoC: poisoning #7236

wants to merge 3 commits into from

Conversation

danieldaeschle
Copy link
Member

@danieldaeschle danieldaeschle commented Dec 10, 2020

https://www.youtube.com/watch?v=bNJhtKPugSQ&feature=youtu.be&t=2912

parser should return error ast nodes instead of exit or stop parsing. checker should collect errors then.

it works with ast.Stmt and ast.Expr but not with other non sum type ast nodes. We need to think about how to design it to make every case work. Also some functions like import_syms or check generates errors, but doesn't return anything.

Problem Example:
making ast.Module to ast.Stmt would result in many if is checks which doesn't garantuee that the checker will run without problems.

We should also take care of scanner errors.

@joe-conigliaro
Copy link
Member

I will have a good look over this and a think.

In any case, we should collect parser errors and checker errors, they are both different stages and we should be able to differentiate between them.

@danieldaeschle
Copy link
Member Author

Since parser errors in the ast, we can set them in checker with a flag that's from the parser. shouldn't be a problem.

@danieldaeschle
Copy link
Member Author

@joe-conigliaro did you have time to think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants