Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

fix(treesitter): always free token contents to prevent a memory leak #446

Closed
wants to merge 2 commits into from
Closed

Conversation

amaanq
Copy link

@amaanq amaanq commented Jun 18, 2023

Detected with libfuzzer

Also just inlined the stack so there's no need to allocate twice for the stack and its data ptr

@medvednikov
Copy link
Member

hey

thanks!

VLS is in the middle of a HUGE re-write, the repo is private atm, but it will be released in July:

https://github.com/v-analyzer

this re-write works great, vlang/vls is currently archived

@amaanq
Copy link
Author

amaanq commented Jun 20, 2023

thanks for the response! Since this is archived, should I submit the changes to v-tree-sitter then? (Projects like nvim-treesitter use this to provide V syntax highlighting support, I can switch the repo to be v-tree-sitter if that's better)

@medvednikov
Copy link
Member

I guess, yeah :)

@i582
Copy link
Contributor

i582 commented Jun 20, 2023

thanks for the response! Since this is archived, should I submit the changes to v-tree-sitter then? (Projects like nvim-treesitter use this to provide V syntax highlighting support, I can switch the repo to be v-tree-sitter if that's better)

Hi
When we release a new version, it will be cool if your changes are pushed there, I will check if I have already fixed them in the current version, since I rewrote the scanner

@i582
Copy link
Contributor

i582 commented Jun 20, 2023

seems to be fixed in my version
Снимок экрана 2023-06-21 в 01 39 02

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants