Add universal wheel support #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wheels are the new standard of python distribution. For detailed information, see PEP 427. https://www.python.org/dev/peps/pep-0427/ For high level information, see: https://pythonwheels.com/ Advantages of wheels * Faster installation for pure Python packages * Avoids arbitrary code execution for installation (avoids setup.py) * Allows better caching for testing and continuous integration * Creates .pyc files as part of installation to ensure they match the python interpreter used * More consistent installs across platforms and machines As this package is pure Pythong (no C files), I have marked the wheel as universal. When you'd normally run "python setup.py sdist upload", run instead "python setup.py sdist bdist_wheel upload".
|
@jdufresne Thank you for updating your pull requests. I'm now considering switching from setuptools to Poetry, so some of the changes in your PRs may not be necessary. See my PR #61, feel free to review it, if you're interested :) |
|
@jdufresne I switched from setuptools to poetry, so wheels are now created automatically by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wheels are the new standard of python distribution.
For detailed information, see PEP 427.
For high level information, see: https://pythonwheels.com/
Advantages of wheels
As this package is pure Pythong (no C files), I have marked the wheel as universal.
When you'd normally run
python setup.py sdist upload, run insteadpython setup.py sdist bdist_wheel upload.