fixed cors origin issue #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travula
reviewed
Mar 14, 2018
src/runtime/config/config.org
Outdated
| @@ -134,7 +134,8 @@ SQLALCHEMY_ECHO = False | |||
| SQLALCHEMY_TRACK_MODIFICATIONS = True | |||
|
|
|||
| # List of allowed origins for CORS | |||
| ALLOWED_ORIGINS = "['*']" | |||
| #ALLOWED_ORIGINS = "['*']" | |||
| ALLOWED_ORIGINS = ["http://outreach.vlabs.ac.in"] | |||
There was a problem hiding this comment.
Checkout link to use regular expressions. The idea is to allow all origins within vlabs.ac.in
There was a problem hiding this comment.
Instead setting up allowed origins in flask configuration, we made same on apache hence this can be ignore
There was a problem hiding this comment.
Allow * here and write the narrative that CORS settings are done in apache and not at flask
|
Sravanthi,
Please validate it based on your readings and understanding. Please share
your observations on the fix
regards
Lalit
…On Wed, Mar 14, 2018 at 10:11 AM, Thirumal Ravula ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/runtime/config/config.org
<#59 (comment)>:
> @@ -134,7 +134,8 @@ SQLALCHEMY_ECHO = False
SQLALCHEMY_TRACK_MODIFICATIONS = True
# List of allowed origins for CORS
-ALLOWED_ORIGINS = "['*']"
+#ALLOWED_ORIGINS = "['*']"
+ALLOWED_ORIGINS = ["http://outreach.vlabs.ac.in"]
Checkout link
<https://flask-cors.corydolphin.com/en/v1.8.0/#flask_cors.cross_origin>
to use regular expressions. The idea is to allow all origins within
vlabs.ac.in
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#59 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALBKUhZZwkF6IhH6uWQV8P3PZkIBTTY8ks5teJ9ggaJpZM4SoJEi>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@travula @lalitsanagavarapu
Requesting you to review the code and let us know if any changes to be done