Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

improve consts and mode naming. #14

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Conversation

vlebourl
Copy link
Owner

@vlebourl vlebourl commented Apr 3, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 3, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.27%.

Quality metrics Before After Change
Complexity 2.06 ⭐ 2.04 ⭐ -0.02 👍
Method Length 30.69 ⭐ 31.00 ⭐ 0.31 👎
Working memory 4.55 ⭐ 4.58 ⭐ 0.03 👎
Quality 87.60% 87.33% -0.27% 👎
Other metrics Before After Change
Lines 182 185 3
Changed files Quality Before Quality After Quality Change
custom_components/vesync/const.py 90.29% ⭐ 89.38% ⭐ -0.91% 👎
custom_components/vesync/humidifier.py 87.11% ⭐ 86.89% ⭐ -0.22% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@github-actions github-actions bot added the enhancement New feature or request label Apr 3, 2022
@vlebourl vlebourl merged commit 00d4d5a into main Apr 3, 2022
@vlebourl vlebourl deleted the enhancement/improve-mode-naming branch April 3, 2022 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant