Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Remove local pyvesync lib and migrate to public one. #25

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Conversation

vlebourl
Copy link
Owner

@vlebourl vlebourl commented Jun 8, 2022

  • Improve extra attributes for humidifiers and fans

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 8, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.90%.

Quality metrics Before After Change
Complexity 4.33 ⭐ 5.73 ⭐ 1.40 👎
Method Length 45.75 ⭐ 38.09 ⭐ -7.66 👍
Working memory 6.84 🙂 6.29 🙂 -0.55 👍
Quality 75.08% 75.98% 0.90% 👍
Other metrics Before After Change
Lines 3753 663 -3090
Changed files Quality Before Quality After Quality Change
custom_components/vesync/init.py 56.94% 🙂 56.94% 🙂 0.00%
custom_components/vesync/common.py 67.17% 🙂 67.17% 🙂 0.00%
custom_components/vesync/config_flow.py 82.10% ⭐ 82.10% ⭐ 0.00%
custom_components/vesync/const.py 88.20% ⭐ 87.48% ⭐ -0.72% 👎
custom_components/vesync/fan.py 82.98% ⭐ 84.56% ⭐ 1.58% 👍
custom_components/vesync/humidifier.py 87.69% ⭐ 87.04% ⭐ -0.65% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
custom_components/vesync/common.py async_process_devices 24 😞 207 ⛔ 8 🙂 41.60% 😞 Refactor to reduce nesting. Try splitting into smaller methods
custom_components/vesync/init.py async_setup_entry 14 🙂 228 ⛔ 10 😞 43.27% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vlebourl vlebourl merged commit d10928e into main Jun 8, 2022
@vlebourl vlebourl deleted the pip-pyvesync branch October 24, 2022 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant