Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Cherry pick from webdjoe/pyvesync #8

Merged
merged 2 commits into from
Apr 3, 2022
Merged

Cherry pick from webdjoe/pyvesync #8

merged 2 commits into from
Apr 3, 2022

Conversation

vlebourl
Copy link
Owner

@vlebourl vlebourl commented Apr 3, 2022

@github-actions github-actions bot added the bug Something isn't working label Apr 3, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 3, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 4.98 ⭐ 4.98 ⭐ 0.00
Method Length 53.87 ⭐ 53.85 ⭐ -0.02 👍
Working memory 6.61 🙂 6.61 🙂 0.00
Quality 73.65% 🙂 73.65% 🙂 0.00%
Other metrics Before After Change
Lines 1223 1223 0
Changed files Quality Before Quality After Quality Change
custom_components/vesync/pyvesync/vesyncfan.py 73.65% 🙂 73.65% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
custom_components/vesync/pyvesync/vesyncfan.py VeSyncAirBypass.get_details 12 🙂 154 😞 10 😞 51.00% 🙂 Try splitting into smaller methods. Extract out complex expressions
custom_components/vesync/pyvesync/vesyncfan.py VeSyncAir131.change_fan_speed 14 🙂 152 😞 9 🙂 51.54% 🙂 Try splitting into smaller methods
custom_components/vesync/pyvesync/vesyncfan.py VeSyncHumid200300S.get_details 12 🙂 146 😞 10 😞 51.84% 🙂 Try splitting into smaller methods. Extract out complex expressions
custom_components/vesync/pyvesync/vesyncfan.py VeSyncAirBypass.change_fan_speed 13 🙂 154 😞 9 🙂 52.18% 🙂 Try splitting into smaller methods
custom_components/vesync/pyvesync/vesyncfan.py VeSyncAir131.get_details 3 ⭐ 131 😞 8 🙂 66.32% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@vlebourl vlebourl linked an issue Apr 3, 2022 that may be closed by this pull request
@vlebourl vlebourl merged commit dde8644 into main Apr 3, 2022
@vlebourl vlebourl deleted the fix/fix-night-light branch April 3, 2022 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pysync bugs
1 participant