Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP DSL #3

Merged
merged 17 commits into from Aug 13, 2018
Merged

HTTP DSL #3

merged 17 commits into from Aug 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2018

  • Split Resource into ConfigurationResource & DynamicResource.
  • Resource class keeps the handlePool's logic
  • Loader keeps using ConfigurationResource (old Resource class)

First DSL steps.

  • DynamicResource needs to:
    • dispatchToHandlerWith be 100% asynchronous
    • matchWith being decoupled of Action.MatchResults class and, instead, have its own implementation
  • ResourceBuilder has the first methods. Still pending to support HTTP basic features:
    • all Methods
    • path variables extraction
    • body mapping
    • headers
    • cookies

First commit hasn't the proper testing, it's meant to show the how it's going.

@VaughnVernon
Copy link
Contributor

@aleixmorgadas Looks great! There seems to be very minimal impact to the existing code base. Do you consider this ready to fly, or do we need the RouteHandler changes first?

@VaughnVernon VaughnVernon merged commit de94239 into vlingo:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant