-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP DSL #3
Merged
Merged
HTTP DSL #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stract methods to Resource class moved allocateHandlerPool, pooledHandler to Resource class
@aleixmorgadas Looks great! There seems to be very minimal impact to the existing code base. Do you consider this ready to fly, or do we need the RouteHandler changes first? |
ghost
mentioned this pull request
Aug 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource
intoConfigurationResource
&DynamicResource
.Resource
class keeps thehandlePool
's logicLoader
keeps usingConfigurationResource
(oldResource
class)First DSL steps.
DynamicResource
needs to:dispatchToHandlerWith
be 100% asynchronousmatchWith
being decoupled ofAction.MatchResults
class and, instead, have its own implementationResourceBuilder
has the first methods. Still pending to support HTTP basic features:First commit hasn't the proper testing, it's meant to show the how it's going.