Skip to content

Commit 9c99e48

Browse files
authored
[Misc] Clean up deadcode for legacy processing pipeline (#24153)
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
1 parent 70549c1 commit 9c99e48

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

tests/models/multimodal/processing/test_tensor_schema.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@
4141
]
4242
REPO_ID_TO_SKIP = {
4343
"nm-testing/pixtral-12b-FP8-dynamic": "duplicated test",
44-
# FIXME(Isotr0py): enable GPT-OSS based InternVL3.5 model
45-
# after support PP for GPT-OSS
46-
"OpenGVLab/InternVL3_5-GPT-OSS-20B-A4B-Preview": "Broken model",
4744
}
4845

4946
ImageInput = list[Image.Image]

vllm/multimodal/utils.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378,10 +378,7 @@ def modality_group_func(
378378
elif len(mm_input) == 1:
379379
return next(iter(mm_input.keys()))
380380

381-
# FIXME(Isotr0py): Modality of mm_input from legacy pipeline is empty,
382-
# this is used to make InternVL with legacy pipeline still work with v1.
383-
else:
384-
return ""
381+
raise AssertionError("This line should be unreachable.")
385382

386383
return [
387384
list(group) for _, group in groupby(mm_inputs, key=modality_group_func)

0 commit comments

Comments
 (0)