Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradio example: remove deprecated parameter concurrency_count #2315

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fix Gradio example: remove deprecated parameter concurrency_count #2315

merged 1 commit into from
Jan 3, 2024

Conversation

ronensc
Copy link
Contributor

@ronensc ronensc commented Jan 1, 2024

Running the gradio example with the latest gradio package (version 4.12.0) results in the following error:

    raise DeprecationWarning(
DeprecationWarning: concurrency_count has been deprecated. Set the concurrency_limit directly on event listeners e.g. btn.click(fn, ..., concurrency_limit=10) or gr.Interface(concurrency_limit=10). If necessary, the total number of workers can be configured via `max_threads` in launch().

It appears that passing concurrency_count to Blocks.queue() has been deprecated. Removing it resolves the issue.

zhuohan123
zhuohan123 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@zhuohan123 zhuohan123 merged commit 1066cbd into vllm-project:main Jan 3, 2024
2 checks passed
@ronensc ronensc deleted the gradio-example-fix branch January 3, 2024 17:57
jedibrillo pushed a commit to jedibrillo/vllm that referenced this pull request Jan 5, 2024
@ronensc
Remove deprecated parameter: concurrency_count (vllm-project#2315)
4557b83
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@ronensc
Remove deprecated parameter: concurrency_count (vllm-project#2315)
d28648b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronensc @zhuohan123