Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor Fix] Remove unused code in benchmark_prefix_caching.py #3171

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

gty111
Copy link
Contributor

@gty111 gty111 commented Mar 4, 2024

Since prefix_pos is not an argument in LLM.generate at present, we should remove it in the benchmark_prefix_caching.py. This may confuse some people who are unfamilar with prefix caching.

#3158

cc @zhuohan123

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@zhuohan123 zhuohan123 merged commit 901cf4c into vllm-project:main Mar 4, 2024
22 checks passed
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants