Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] improve robustness of pynccl #3860

Merged
merged 2 commits into from
Apr 4, 2024
Merged

[Core] improve robustness of pynccl #3860

merged 2 commits into from
Apr 4, 2024

Conversation

youkaichao
Copy link
Member

Fixes #3858 , and avoid using args because they can be -1 . Use self.rank etc instead.

WoosukKwon
WoosukKwon approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@youkaichao youkaichao merged commit c391e4b into main Apr 4, 2024
35 checks passed
@youkaichao youkaichao deleted the robust_nccl branch April 4, 2024 23:52
@youkaichao youkaichao mentioned this pull request Apr 5, 2024
Open
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request Apr 22, 2024
@youkaichao @joerunde
[Core] improve robustness of pynccl (vllm-project#3860)
c7a94dd
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] PyNCCL errors at termination
2 participants
@youkaichao @WoosukKwon