[Core] Introduce DistributedGPUExecutor abstract class
#4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a superclass of RayGPUExecutor, in preparation for introducing a sibling MultiprocessingGPUExecutor
youkaichao
reviewed
Apr 25, 2024
…utor_hierarchy # Conflicts: # vllm/executor/ray_gpu_executor.py
youkaichao
approved these changes
Apr 25, 2024
|
Another concern is the naming. I suggest something like |
|
@youkaichao so you think |
|
Yes, I think |
njhill
changed the title
MultiGPUExecutor abstract classDistributedGPUExecutor abstract class
…utor_hierarchy # Conflicts: # vllm/executor/ray_gpu_executor.py
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 6, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a superclass of
RayGPUExecutor, in preparation for introducing a siblingMultiprocessingGPUExecutor.There is no new logic here, it's just moving some methods into a the superclass.