-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix empty (nullptr) channelwise scales when loading wNa16 using compressed tensors #6798
[Bugfix] Fix empty (nullptr) channelwise scales when loading wNa16 using compressed tensors #6798
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
cdbe26d
to
a3b0efa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking this down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice debugging, thank you!
…ing compressed tensors (vllm-project#6798)
…ing compressed tensors (vllm-project#6798)
…ing compressed tensors (vllm-project#6798) Signed-off-by: Alvant <alvasian@yandex.ru>
When running row parallel with channelwise scales, the integer divide in:
would result in a 0 sized tensor (with shape
(0, 8192)
, i.e.tensor([], device='cuda:2', size=(0, 8192), dtype=torch.bfloat16)
) leading to a nullptr getting passed into marlin.This is because when its channelwise
group_size
was getting set toinput_size
which is greater thaninput_size_per_partition
in the row parallel case when tp > 1Now for channelwise scales when running row parallel with a tp > 1 we replicate the scales to all gpus.
This issue was present for the model: "nm-testing/Meta-Llama-3.1-70B-Instruct-quantized.w8a16"