Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scala 2.13 #244

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Add support for Scala 2.13 #244

merged 1 commit into from
Aug 27, 2019

Conversation

vlovgr
Copy link
Owner

@vlovgr vlovgr commented Aug 23, 2019

Adds support for Scala 2.13 to all modules but ciris-squants (see typelevel/squants#344).

While adding support for Scala 2.13, the following changes have been made.

  • Drop support for Scala 2.11.
  • Drop support for Scala.js and Scala Native.
    • Looking at download figures, there's not much interest in Ciris for these platforms.
    • The build.sbt build configuration becomes significantly easier to manage.
    • No need for platform-specific sources, makes code easier to manage.
  • Remove the 'Creating new modules' section from the contributing guide.
    • It needs re-writing after significant changes to build.sbt.
  • Tests have been split from the tests project into individual modules.
    • Squants is still not available for Scala 2.13, so prevents tests from being run.
    • Splitting the tests allows us to run them on 2.13 for modules with 2.13 support.

Fixes #220, replaces #243.

@vlovgr vlovgr mentioned this pull request Aug 23, 2019
1 task
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #244 into master will decrease coverage by 1.24%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   99.09%   97.85%   -1.25%     
==========================================
  Files          47       44       -3     
  Lines         885      885              
  Branches        7       12       +5     
==========================================
- Hits          877      866      -11     
- Misses          8       19      +11
Impacted Files Coverage Δ
...main/scala/ciris/decoders/MathConfigDecoders.scala 100% <ø> (ø)
...ala/ciris/decoders/JavaNioFileConfigDecoders.scala 100% <ø> (ø)
...dules/core/src/main/scala/ciris/ConfigErrors.scala 100% <ø> (ø)
...odules/core/src/main/scala/ciris/ConfigError.scala 100% <ø> (ø)
...n/scala/ciris/decoders/JavaNetConfigDecoders.scala 100% <ø> (ø)
...ules/core/src/main/scala/ciris/ConfigResults.scala 100% <ø> (ø)
.../scala/ciris/decoders/JavaUtilConfigDecoders.scala 100% <ø> (ø)
...ciris/generic/decoders/GenericConfigDecoders.scala 100% <ø> (ø)
...rc/main/scala/ciris/api/syntax/FlatMapSyntax.scala 100% <ø> (ø)
...odules/core/src/main/scala/ciris/api/package.scala 100% <ø> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddabdb3...7aff6cb. Read the comment docs.

@vlovgr vlovgr merged commit fbbecec into master Aug 27, 2019
@vlovgr vlovgr deleted the scala-2.13 branch August 27, 2019 11:10
@vlovgr vlovgr mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross Compile to 2.13
1 participant