Scope issue setHeaders #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for 'ReferenceError' in expectHeader* methods
|
Hey Vance, I've pushed another fix for the globalSetup not being properly reset between tests. One issue was if you were setting headers on a test, they would carry on and overwrite all the other tests. It would be great if you could push this to NPM as well. Thanks! |
|
I just merged in the setHeaders fix (good catch!), but the globalSetup stuff is a separate issue. I checked out the code, and some tests do not pass with the globalSetup code changes you made. Please open a separate issue ticket and/or separate pull request so I can take a look at that code too and we can discuss it further. If you want to run the Frisby tests yourself to see which tests fail with globalSetup, run: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3: #3