[linux] use gnu readline for linux console cli #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on windows, works as expected :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Use GNU Readline to do CLI input on Linux. Lets you have a command history and edit commands inline. This also opens up tab completion that can be implemented at some point.
Windows users still get the old way of doing input via fgets reading stdin...
I moved some of the world stopping stuff out of the CLI files too and into the main function that creates and destroys it all.
Proof
Issues
How2Test
libreadline-dev)Console.Enableis enabled in mangosd.conf and try some commands! Use the arrow keys on your keyboard :)Todo / Checklist