Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MoveMapGen exit codes. #2558

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

mserajnik
Copy link
Contributor

🍰 Pullrequest

Currently, MoveMapGen exits with 1 once it has completed successfully, which would indicate an error.
It also exits with -1, -2 and -3 in various error scenarios but there doesn't seem to be a good reason to differentiate using different codes to begin with and even less reason to use negative values.

This changes the exit codes to use EXIT_SUCCESS and EXIT_FAILURE from the cstdlib header (which should be preferable over using 0 and 1 directly because it makes the code more portable).

Proof

  • None

Issues

  • None

How2Test

  • None

Todo / Checklist

  • None

@ratkosrb ratkosrb merged commit e2d8d78 into vmangos:development Mar 20, 2024
3 checks passed
@mserajnik mserajnik deleted the fix-movemapgen-exit-codes branch March 20, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants