-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When on level "0": Unexpected short fan activation. #114
Comments
Hi, that sounds like a bug that has been fixed for a very, very long time now. I think it should already be fixed in the 0.9.3 release, and that would be from 2016. Since then thinkfan has undergone a complete redesign and we're currently at 1.2.1. Someone (preferrably a Ubuntu user, cough cough) should ping the package maintainer and tell them to update ;-) |
oh, and are you actually serious about keeping the fan off until your temperature has reached 85°C? I don't know what you're (not) cooling there, but 85°C sounds awfully hot for any device... |
Thanks a lot, @vmatare ! |
That was only a test script, I don't intend to use it further.
However, I still have the problem of unexpected short fan activation. |
Yes, upgrade at least to 0.9.3. Even Debian have it in their stable repos: https://packages.debian.org/stable/thinkfan And then, to wake up the Ubuntu people you should report it as a Ubuntu bug: https://bugs.launchpad.net/ubuntu |
What I forgot to say, the problem is at the moment with thinkfan version 1.2 , so downgrading to 0.9.3 might fix it? :)
Ok, I will try this then. |
Sorry, I just saw that thinkfan 0.9.3 incorrectly reports its version number as 0.9.1. So it's likely that your package database says 0.9.3, while Oh, and please don't downgrade, I don't believe that will fix your problem. If you actually observed this problem with 1.2 or 1.2.1, it might be something I need to look at. So are you saying the behavior is exactly the same as with the old 0.9 version? |
thinkfan 1.2: A minimalist fan control program
This is exactly what I did, and the problem is still there. EDIT: And yes, the behaviour is the exact same as from version 0.9. |
Which command line options are you using when you launch thinkfan? In particular, are you using the |
Hi @vmatare , sorry, I somehow overlooked your last message. Tanks again for helping me with this. $ sudo thinkfan -s 10
/proc/acpi/ibm/fan: Restoring initial state: auto.
Daemon PID: 30651 $ sudo thinkfan -p
Disengaging the fan controller for 5 seconds every 0.500000 seconds
/proc/acpi/ibm/fan: Restoring initial state: auto.
Daemon PID: 30207 |
@vmatare : any ideas maybe? |
I have the same issue on my Thinkpad T14s (AMD) running Arch. Whenever /proc/acpi/ibm/fan is written to (even writing 0), the fan will spin for half a second. Since thinkfan seems to write to this every 120 seconds, the fan spins every 120 seconds. Changing the number on line 84 of drivers.cpp for watchdog_timeout changes how often the fan spins Line 84 in eab6f5b
One possible fix could be to disable watchdog. Setting timeout to 0 in code does not seem to work because it will cause thinkfan to repeatedly write to /proc/acpi/ibm/fan, running the fan constantly. |
@vmatare I'm not personally affected by this (the fan in my T430 never gets to zero...), but came here via a reddit post about this issue. The user claims that writing Thought it was worth mentioning, so maybe someone affected can test/confirm that here. |
affected and can confirm. then AMD T14 Gen2 spins the fan up very briefly even when turning it off. this patch is sufficient to stop the 2-minutely spinup while preventing watchdog reset (on 1.3.1) diff --git a/src/fans.cpp b/src/fans.cpp
index 56a15d7..08c9b4a 100644
--- a/src/fans.cpp
+++ b/src/fans.cpp
@@ -123,7 +123,11 @@ void TpFanDriver::ping_watchdog_and_depulse(const Level &level)
}
else if (last_watchdog_ping_ + watchdog_ - sleeptime <= std::chrono::system_clock::now()) {
log(TF_DBG) << "Watchdog ping" << flush;
- set_speed(level);
+ std::fstream f(path_);
+ if (!(f.is_open() && f.good()))
+ throw IOerror(MSG_FAN_INIT(path_), errno);
+ if (!(f << "watchdog " << watchdog_.count() << std::flush))
+ throw IOerror(MSG_FAN_INIT(path_), errno);
}
} |
I'm affected and can confirm that the patch works with 1.3.1 on a T495 (actually a T490 with AMD CPU). |
@peter-stoll, I stumbled upon this thread while facing the issue myself and I took the matter into my own hands. A pull request (see above) was submitted ; it is pending review and merging by @vmatare. |
I have a Thinkpad T495 Ubuntu 20.4 and want to use Thinkfan, as I don't want to have fan noises when e.g. watching videos.
I installed
thinkfan 0.9.1
, and it workes more or less, except that about every two minutes, the fan is starting to spin but also stopping immediately (starting+stopping takes maybe 3 seconds) at low temperatures (~45°C), where I would expect level 0.My file
/etc/thinkfan.conf
looks like this:Can someone maybe give me any advice?
My theory is that the Ubuntu internal and the think fan scripts to control the fan are interfering somehow.
Thanks a lot!
The text was updated successfully, but these errors were encountered: