Extend Makefile to produce shared libraries #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged. A shared library would be super useful for this. |
|
Since this is needed for the Python wrapper, I also think this would be a great addition. |
|
I considered providing shared libraries when I created Makefile for houdini. But somehow I felt @vmg wanted to be free from maintenance work. Heck, that is why there was no makefile at all, I guess. Static lib is convenient and doesn't burden anyone. You cannot say that about dynamic lib. Mind that doing shared libraries requires versioning them, which you (conveniently :>) omitted. I can provide simple boilerplate for Linux-case ( |
|
+1 |
|
Ramsalmgroup |
|
Daniel Ramos Navarro |
This was referenced Jan 9, 2021
Matausi29
approved these changes
Oct 9, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m hacking together a Python interface to this library using ctypes, which means I needed a shared object file (
.dylibon OS X,.soon Linux). This small PR just adds an appropriate target on each of those OSes; I’ve tested it on both so far (thanks to Vagrant) and it seems to work.