Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolink of "(URL is http://example.com.)" includes the final period #46

Closed
minux opened this issue Feb 20, 2015 · 3 comments
Closed

Autolink of "(URL is http://example.com.)" includes the final period #46

minux opened this issue Feb 20, 2015 · 3 comments

Comments

@minux
Copy link

minux commented Feb 20, 2015

Autolink of "URL is http://example.com/dir." is:
URL is <a href="http://example.com/dir">http://example.com/dir</a>.

whereas autolink of "(URL is http://example.com/dir.)" is
(URL is <a href="http://example.com/dir.">http://example.com/dir.</a>)

@ryanseys
Copy link

Didn't work for your above example either where the last character is a double quote.

"URL is http://example.com/dir." --> "URL is <a href="http://example.com/dir.">http://example.com/dir.</a>"

@kivikakk
Copy link
Contributor

kivikakk commented Oct 6, 2016

I do see the first example as working, and the second example as failing:

>> Rinku.auto_link 'URL is http://example.com/dir.'
=> "URL is <a href=\"http://example.com/dir\">http://example.com/dir</a>."
>> Rinku.auto_link '(URL is http://example.com/dir.)'
=> "(URL is <a href=\"http://example.com/dir.\">http://example.com/dir.</a>)"

Will look into this.

@kivikakk
Copy link
Contributor

kivikakk commented Oct 7, 2016

This is fixed as of #61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants