Replace travis with github actions #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
force-pushed
the
chore/github-actions
branch
from
0b44fd4
to
9a10f7f
Compare
lilien1010
reviewed
Sep 3, 2021
|
|
||
| // Version is the current release version. | ||
| func Version() string { | ||
| return "0.0.0" |
There was a problem hiding this comment.
should we specifc the version as the tag version , eg 3.2.4
There was a problem hiding this comment.
This will be filled automatically by release.sh script
lilien1010
reviewed
Sep 3, 2021
| @@ -0,0 +1,19 @@ | |||
| name: golangci-lint | |||
There was a problem hiding this comment.
maybe we can add a .golangci.yml?
linters-settings:
funlen:
lines: 100
statements: 75
gocritic:
disabled-checks:
- exitAfterDefer
linters:
disable:
- errcheck
enable:
- bodyclose
- deadcode
- depguard
- dogsled
- dupl
- exhaustive
- funlen
- gochecknoinits
- goconst
- gocritic
- gocyclo
- gofmt
- goimports
- golint
- goprintffuncname
- gosimple
- govet
- ineffassign
- misspell
- nakedret
- noctx
- nolintlint
- rowserrcheck
- scopelint
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
- unused
- varcheck
- whitespace
There was a problem hiding this comment.
Not sure... It works without a config well enough and I don't want to learn & maintain golangci-lint config :) If you already have a config that you use in other projects - please send a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.