Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerpc64 / ppc64le support #237

Merged
merged 3 commits into from
Jul 28, 2021
Merged

powerpc64 / ppc64le support #237

merged 3 commits into from
Jul 28, 2021

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Jul 13, 2021

WIP - not working yet and looking for feedback.

A few questions:

  • Where are unwind-aarch64 etc. built? Edit: Nevermind, fixed in aa02cc7
  • What is the purpose of the vmprof_eval function?

cc: @fijal @mattip

@matthiasdiener matthiasdiener marked this pull request as draft July 13, 2021 22:04
@matthiasdiener matthiasdiener changed the title initial powerpc64 / ppc64le support powerpc64 / ppc64le support Jul 13, 2021
@matthiasdiener
Copy link
Contributor Author

Current status: It works on powerpc64, but only for the Python callstack:

$ vmprofshow vmprof_cpuburn.dat tree
100.0%  <unknown code>  100.0%  <unknown>
100.0% |. test  100.0%  vmprof/test/cpuburn.py:36
100.0% |.|. burn  100.0%  vmprof/test/cpuburn.py:27
100.0% |.|.|. _iterate  100.0%  vmprof/test/cpuburn.py:20
 51.6% |.|.|.|. _next_rand  51.6%  vmprof/test/cpuburn.py:15

Not sure if this is a libbacktrace or libunwind issue.

@matthiasdiener matthiasdiener marked this pull request as ready for review July 17, 2021 15:58
@matthiasdiener
Copy link
Contributor Author

matthiasdiener commented Jul 17, 2021

It seems that native profiling is not available in ppc64le (no getcontext in libunwind libunwind/libunwind#33), so setting this as ready for review.

@matthiasdiener
Copy link
Contributor Author

Gentle ping for @fijal @mattip for a review.

@mattip mattip merged commit 133ad3c into vmprof:master Jul 28, 2021
@mattip
Copy link
Contributor

mattip commented Jul 28, 2021

Thanks @matthiasdiener

@mattip
Copy link
Contributor

mattip commented Jul 28, 2021

Since we are running CI on travis, I think it would be nice to add a ppc64le job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants