This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(dropdown): set min height and width for angle icon #6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cory Rylan <splintercode.cb@gmail.com>
Signed-off-by: Steve Haar <info@stevehaar.com>
The assertions in these four tests were not being executed due to improper use of fakeAsync. Signed-off-by: Steve Haar <info@stevehaar.com>
fixes vmware-archive#5967 The default icon size was 16px and the spinner was 18px causing an ellipsis to show Signed-off-by: Steve Haar <info@stevehaar.com>
When getting staged files, an additional empty string was included which caused all files to be committed even if they didn't have any staged changes. Signed-off-by: Steve Haar <info@stevehaar.com>
Signed-off-by: Steve Haar <info@stevehaar.com>
- @cds/core is now setting min height and width for all icons. So height and width override in dropdown was having no effect. Signed-off-by: gerinjacob <gerinjacob@gmail.com>
|
Hi @gerinjacob, Thank you for the contribution. I would like to take some time to check if this is the optimal solution. The base should be |
|
@bbogdanov , created PR - #6558 for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So height and width override in dropdown was having no effect. Added min height and width.
Signed-off-by: gerinjacob gerinjacob@gmail.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Size of angle icon inside dropdown is bigger, since it ignores the height and width values set in dropdown style.
min-height and min-width set as part of 629537a is causing this issue.
Issue Number: N/A
What is the new behavior?
In addition to height and width also set min height and width in dropdown style.
Does this PR introduce a breaking change?
Other information