Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Fix KAFKA_BROKERS so that it uses strings split on ',' #25

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Fix KAFKA_BROKERS so that it uses strings split on ',' #25

merged 1 commit into from
Jun 26, 2020

Conversation

jon-whit
Copy link
Contributor

@jon-whit jon-whit commented Jun 25, 2020 •
edited by andresmgot
Loading

Fixes #8

Description: The changes herein fix a known issue with the KAFKA_BROKERS not working with a list of brokers delimeted by a comma.

andresmgot
andresmgot approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We need to update the tests here for Golang but the code LGTM

@andresmgot andresmgot merged commit 51658b4 into vmware-archive:master Jun 26, 2020
@jon-whit
Copy link
Contributor Author

@andresmgot you're welcome! Thanks for merging it quickly 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresmgot andresmgot andresmgot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KAFKA_BROKERS string is not correctly split to broker list (slice)
2 participants
@jon-whit @andresmgot