AWSIoT DCC, examples, README #71

Venkat2811 · 2017-01-17T15:14:36Z

Fix for #63

AWSIoT DCC and example with various options available with LIOTA's MQTT
Added README.md for MQTT
Moved store_edge_system_uuid from iotcc.py > utility.py so that it can be used by Mqtt Dcc also.
Moved lib/identity > 'lib/utility'

KohliDev · 2017-01-27T09:45:33Z

examples/mqtt/aws_iot/simulated_home_auto_gen_topic.py

+    #  Encapsulates Identity Parameters related to Dcc
+    dcc_identity = RemoteSystemIdentity(root_ca_cert=config['broker_root_ca_cert'], username=None, password=None)
+    #  Encapsulates Identity Parameters related to EdgeSystem
+    edge_system_identity = EdgeSystemIdentity(edge_system=edge_system, cert_file=config['edge_system_cert_file'],


EdgesystemIdentity can be part of edge_system, let's not create a separate entity. Same rule applies for dcc_identity. And we should make this changes for iotcc.py and its examples as well.

KohliDev · 2017-01-27T09:46:34Z

examples/mqtt/README.md

+LIOTA's Mqtt client supports both Username-password based authentication & certification based authentication.  Users can configure appropriate parameters using these objects
+while initializing MqttDeviceComms and MqttDccComms:
+
+* ![EdgeSystemIdentity & RemoteSystemIdentity](/liota/lib/identity/identity.py)


Remove this part related to EdgeSystemIdentity as it will become part of EdgeSystem and make it part of main README.md

As discussed, this will be part of transports. So, this will not be added to README.md

KohliDev · 2017-01-27T09:48:50Z

examples/mqtt/README.md

+* Publish retain flag will be **False** and
+* Subscribe call_back will be **None**
+
+**(b)** Use custom single publish and subscribe topic for an EdgeSystem, its Devices and Metrics.


Add that other then Point (a) you have to mention the custom parameters(Topics, QoS Level, flag etc.) in sampleProp.conf file (give the path of sampleProp.conf file for reference)

KohliDev · 2017-01-27T09:49:32Z

examples/mqtt/README.md

+* ![TLSConf](/liota/lib/identity/tls_conf.py)
+
+## QoS
+LIOTA also supports configuration of QoS related parameters like in_flight size, queue_size and retry timeout using **QoSDetails class** in ![mqtt.py](/liota/lib/transports/mqtt.py).


No need to refer mqtt.py

KohliDev · 2017-01-27T09:52:01Z

examples/mqtt/README.md

+it follows `Option (a)` as mentioned in the above section.
+* **Option (a)** could be achieved by passing **mqtt_msg_attr=None while initializing MqttDccComms**.
+
+Examples for this will be provided once the development is complete.


Remember to update this line later or remove it

I'll remember.

I'll remove it

KohliDev · 2017-01-27T09:56:54Z

examples/mqtt/aws_iot/simulated_home_topic_per_metric.py

+    reg_light_metric = aws.register(light_metric)
+    aws.create_relationship(reg_light_sensor, reg_light_metric)
+    #  Publish topic for this Metric
+    reg_light_metric.msg_attr = MqttMessagingAttributes(pub_topic='home/living-room/light')


Mention a comment here that custom topic can also be referred from sampleProp.conf file and user should take care of referring it correctly.

KohliDev · 2017-01-27T09:58:28Z

liota/dccs/generic_mqtt.py

+    """
+    def __init__(self, con, enclose_metadata=False):
+        """
+        :param con: AWSMQTTDccComms Object


Generic MQTT Object not AWSMQTTDccComms

KohliDev · 2017-01-27T10:00:01Z

liota/dccs/generic_mqtt.py

+    def _get_entity_hierarchy(self, reg_entity):
+        """
+        :param reg_entity: RegisteredMetric Object
+        :return: Entity hierarchy delimited by '->'


Don`t use delimiter use an array or map or any other data structure.

KohliDev · 2017-01-27T10:09:15Z

README.md

@@ -31,6 +31,9 @@ or a traditional socket endpoint.
 ## DCC (Data Center Component)
 The abstract class DCC represents an application in a data-center. It is potentially the most important and complex abstraction of liota. It provides flexibility to developers for choosing the data-center components they need and using API’s provided by liota. With help of this abstraction developers may build custom solutions. The abstract class states basic methods and encapsulates them into unified common API’s required to send data to various DCC’s. Graphite and Project Ice are currently the data-center components supported with AWS, BlueMix and ThingWorx to come soon. New DCC’s can easily be integrated in the abstraction.

+## Transports


Mention in the README.md that Gateway object should be created before creating DCC_comms object. And also how to set the Edge system identity and DCC identity should be made part of main REDME.md

KohliDev · 2017-01-27T10:15:40Z

liota/dccs/generic_mqtt.py

+        """
+        _list = []
+        met_cnt = reg_metric.values.qsize()
+        if met_cnt > 0:


met_cnt is zero then we`ll be sending a blank metric_data payload? Will it get filtered out later?

It should have been if met_cnt == 0 return.

KohliDev · 2017-02-01T13:45:31Z

examples/mqtt/aws_iot/simulated_home_auto_gen_topic.py

+    #  Initializing GenericMqtt DCC using MqttDccComms
+    #  AWSIoT broker doesn't support session persistence.  So, always use "clean_session=True"
+    #  Publish topic for all Metrics will be 'liota/generated_local_uuid_of_edge_system'
+    aws = GenericMqtt(MqttDccComms(edge_system=edge_system, url=config['BrokerIP'], port=config['BrokerPort'],


Edge_system to hold name as well as client certificates, don't take them individually in any DCC_comms. Also, Make edge_system to be passed to all the DCC_Comms.

KohliDev · 2017-02-06T08:04:52Z

examples/mqtt/dcc_comms/aws_iot/sampleProp.conf

+retry = 5
+CustomPubTopic = "home/gateway/metrics"
+LivingRoomTempTopic = "home/living-room/temperature"
+LivingRoomHumTopic = "home/living-room/humidity"


LivingRoomHumidityTopic

KohliDev · 2017-02-06T08:12:30Z

examples/mqtt/README.md

+LIOTA offers MQTT protocol as transport at both Device & DCC ends via ![MqttDeviceComms](/liota/device_comms/mqtt_device_comms.py) & ![MqttDccComms](/liota/dcc_comms/mqtt_dcc_comms.py).
+
+
+## QoS


Also, explain about credentials and TLS_Conf details which can be passed using the Utilities.

KohliDev · 2017-02-06T08:16:33Z

liota/lib/utilities/utility.py

+
+class Credentials:
+    """
+    This class encapsulates credentials related to a connection  both at Dcc and Device side.


This class encapsulates certificates or credentials related to a connection used at both DCC and Device side.

pmasrani · 2017-02-16T14:15:27Z

README.md

@@ -22,7 +24,7 @@ The Metric subclass of Entity is the local object representing a stream of (numb
 The abstract class DeviceComms represent mechanisms through which devices send and receive data to/from edge systems. Some examples are CAN bus, Modbus, ProfiNet, Zibgee, GPIO pins, Industrial Serial Protocols as well as sockets, websockets, MQTT, CoAP. The DeviceComms abstract class is a placeholder for these various communication mechanisms. 

 ## DCCComms
-The abstract class DCCComms represents communication protocols between edge systems and DCCs. Currently, liota supports WebSocket and plain old BSD sockets. In near future it will support MQTT and CoAP. Both are ‘Session’ or layer-5 protocols. MQTT is a pub-sub system using TCP and CoAP implements reliable UDP datagrams and a data format specification. These protocols are capable of satisfying most of the use cases for transferring data from IoT gateways to data-center components. With the current implementation the gateway acts as either a WebSocket client, establishing a connection with the server using the WebSocket protocol. e.g.
+The abstract class DCCComms represents communication protocols between edge systems and DCCs. Currently, liota supports MQTT, WebSocket and plain old BSD sockets. In near future it will support CoAP. Both are ‘Session’ or layer-5 protocols. MQTT is a pub-sub system using TCP and CoAP implements reliable UDP datagrams and a data format specification. These protocols are capable of satisfying most of the use cases for transferring data from IoT gateways to data-center components. With the current implementation the gateway acts as either a WebSocket client, establishing a connection with the server using the WebSocket protocol. e.g.


Both are ‘Session’ or layer-5 protocols? Which both? Needs rewrite.

I edited In near future it will support MQTT and CoAP line alone. Didn't notice this. Will rewrite.

WebSocket, MQTT and CoAP are both application layer (layer-7) protocols. https://en.wikipedia.org/wiki/Category:Application_layer_protocols

pmasrani · 2017-02-18T08:54:36Z

examples/mqtt/README.md

+LIOTA also supports configuration of QoS related parameters like in_flight size, queue_size and retry timeout using **QoSDetails class**.
+
+
+## Credentials and TLS Configurations


Since Credentials class is generic, not specific for MQTT, i think it will be better to document it in common Readme, not in MQTT readme.

pmasrani · 2017-02-18T09:09:11Z

examples/mqtt/README.md

+It enables the following options for developers in LIOTA.
+
+**(a)** Use single publish and subscribe topic generated by LIOTA for an EdgeSystem, its Devices and its Metrics. By default:
+* Publish topic for all Metrics will be **liota/generated_local_uuid_of_edge_system**


Might be a good idea to consider liota/request/generated_local_uuid_of_edge_system and liota/response/generated_local_uuid_of_edge_system as topics. This way, if required some client can subscribe to all communication and some to just requests and some to just responses. Also, current naming is not very obvious. It's difficult to figure out from topic names what it stands for. liota-resp also seems to be unnecessarily shortened.

Using liota/stats/local_uuid and liota/response/local_uuid instead.

I think we can refactor it more:
liota/gw-uuid/requests
&
liota/gw-uuid/response

Gives much more subscription possibilities.

Yea. This will give edge_system level subscription.

Will use stats instead of requests as it'll suit much better.

pmasrani · 2017-02-18T09:10:39Z

examples/mqtt/README.md

+
+**(b)** Use custom single publish and subscribe topic for an EdgeSystem, its Devices and Metrics.  Along with custom topics, other parameters (QoS, retain_flag ,etc.,) can be referred from ![Property File](/examples/mqtt/aws_iot/awsSampleProp.conf).
+
+**-** In the above two cases, MQTT message's payload MUST be self-descriptive so that subscriber can subscribe process accordingly to a single topic by parsing payload.


Can you please elaborate more, using an example, what is self-descriptive?

Yea there is an example. Will provide reference to it.

Self-Descriptive means when each metric is published, its edge_system's_name, device's_name will also be appended. IoTCC does it by appending uuids, GenericMqtt Dcc does it with a configurable Boolean parameter enclose_metadata

pmasrani · 2017-02-18T09:16:23Z

examples/mqtt/dcc_comms/aws_iot/simulated_home_auto_gen_topic.py

+
+
+#  Random number generator, simulating living room temperature readings.
+def living_room_temperature():


get_living_room_temperature instead of just living_room_temperature?

pmasrani · 2017-02-18T09:22:08Z

examples/mqtt/dcc_comms/aws_iot/simulated_home_auto_gen_topic.py

+    #  Initializing GenericMqtt DCC using MqttDccComms
+    #  AWSIoT broker doesn't support session persistence.  So, always use "clean_session=True"
+    #  Publish topic for all Metrics will be 'liota/generated_local_uuid_of_edge_system'
+    aws = GenericMqtt(MqttDccComms(edge_system_name=edge_system.name, url=config['BrokerIP'], port=config['BrokerPort'],


Can you format this better, one parameter per line?

Instead of one parameter per line, grouping related parameters together in one line.

pmasrani · 2017-02-19T06:21:55Z

examples/mqtt/README.md

+
+
+### Configuration for Non-ProjectICE Scenario
+![GenericMqtt DCC](/liota/dccs/generic_mqtt.py) is a Data Center Component to connect with MQTT brokers using LIOTA in non-ProjectICE scenarios.  **Options (a), (b), (c) and (d)** mentioned in the above section


I believe there is a design flaw here. DCCs should not be very specific to protocols. That's the very reason of extracting out DCCComms as separate module. Hence, i see AWSIoT as DCC and we can have AWSIoT over MQTT, HTTP or MQTT + WebSocket (http://docs.aws.amazon.com/iot/latest/developerguide/protocols.html). It seems incorrect to implement AWSIoT as GenericMQTT.

Conventional MQTT is MQTT over TCP and there is also support for MQTT over WebSocket. Most of the MQTT brokers (AWS, EMQTT, etc.,) support it. There is no difference in configurations except for parameter transport in MQTT configuration.

Yes. That would be a DCC specific to AWSIoT only. Here what we are trying to showcase is that, MQTT support in LIOTA is generic so that it can be used to publish data to any DCC that supports MQTT. As of now, this example showcases publishing data to AWSIoT over MQTT. Examples using Azure is ready https://github.com/Venkat2811/liota/tree/azure-example/examples/mqtt/azure_iot. We're working on IBM Bluemix too. Once we have support for multiple transports like, HTTP-REST, AMQP, we can provide platform specific Dcc. We're planning to raise Azure and IBM examples as separate PR

pmasrani · 2017-02-19T06:27:13Z

liota/lib/utilities/utility.py

+    return value
+
+
+class Credentials:


Any specific reason we moved away from identity module and included this in utility? We should try to provide only very basic read/write kind of functionality in utility and not include many disjoint classes/methods here. We also have to rename this file and probably split it into multiple files based on functionalities.

EdgeSystemIdentity and RemoteSystemIdentity didn't suit well. Credentials will be simply a data object (utility) that holds cert paths and credentials used in various classes. Goal is to reduce number of constructor params of DccComms & DeviceComms related to Credentials. So, we thought why to create a separate module for this and kept it in Utility itself.

pmasrani · 2017-02-19T07:14:37Z

examples/mqtt/README.md

+Configuring MqttDccComms and MessagingAttributes for ProjectICE and non-ProjectICE related use-cases is explained in the following sections.
+
+### Configuration for ProjectICE Scenario
+![IoTCC DCC](/liota/dccs/iotcc.py) will support both WebSockets and MQTT as transports.  **This is WIP**.  Once developed it'll allow plug-and-play approach to easily switch between these two protocols.  However, for MQTT


Why do we have to do separate configuration for project ICE?

In Project ICE, publish topic would be liota/generated_local_uuid. In non-Project ICE it need not be the case. So, there is separate configuration for non-project ICE. For Project ICE scenarios, it'll remain similar to existing configuration.

pmasrani · 2017-02-19T07:16:50Z

examples/mqtt/dcc_comms/aws_iot/sampleProp.conf

+broker_root_ca_cert = "/etc/liota/mqtt/conf/ca.crt"
+broker_username = None
+broker_password = None
+edge_system_cert_file = "/etc/liota/mqtt/conf/client.crt"


Shouldn't this location be /etc/liota/conf/mqtt/ ? All configurations should go together, and MQTT configurations be specific, isn't it? Also, will other DCCComms not need client.crt and client.key? Why this has to be specific to mqtt?

We didn't decide on location for cert files as they are user defined and path is obtained from sampleProp.conf and not from liota.conf. However, for representation, it can be /etc/liota/conf/mqtt/.

If a platform supports certificate based authentication, DCCComms will need them. If we're publishing to two different DCCs, certificates might (not always) be different.

KohliDev · 2017-03-15T20:01:56Z

examples/mqtt/device_comms/iot_cc/iotcc_simulated_mqtt.py

@@ -41,10 +41,8 @@
 from liota.entities.devices.simulated_device import SimulatedDevice


rename folder mqtt/iotcc

iot_cc creates confusion

okay. Will change to mqtt/device_comms/iotcc

KohliDev · 2017-03-15T20:05:13Z

liota/dcc_comms/mqtt_dcc_comms.py

-                 userdata=None, protocol="MQTTv311", transport="tcp", mqtt_msg_attr=None, keep_alive=60,
-                 enable_authentication=False, conn_disconn_timeout=10):
+    def __init__(self, edge_system_name, url, port, identity=None, tls_conf=None, qos_details=None,
+                 client_id="", clean_session=False, userdata=None, protocol="MQTTv311", transport="tcp", keep_alive=60,


Why is client_id changed from None to "" ?

keeping it consistent with paho library

KohliDev · 2017-03-15T20:09:54Z

setup.py

+                 ['examples/mqtt/device_comms/iot_cc/iotcc_simulated_mqtt.py',
+                  'examples/mqtt/device_comms/iot_cc/samplePropMqtt.conf']),
+                (os.path.abspath(os.sep) + '/../etc/liota/examples/mqtt/dcc_comms/aws_iot',
+                 ['examples/mqtt/dcc_comms/aws_iot/sampleProp.conf',


Add all of this extra packages to Manifest.in

KohliDev

Raise a small PR next time for faster review.

KohliDev · 2017-03-15T20:14:40Z

liota/dccs/aws_iot.py

+
+        reg_entity_child.parent = reg_entity_parent
+
+    def _get_entity_hierarchy(self, reg_entity):


Add a comment this might be taken out in utilities if other DCC requires hierarchy.

pmasrani · 2017-03-13T10:13:47Z

examples/mqtt/README.md

+**(a)** Use single publish and subscribe topic generated by LIOTA for an EdgeSystem, its Devices and its Metrics. By default:
+* Publish topic for all Metrics will be **liota/generated_local_uuid_of_edge_system/request**
+* Subscribe topic will be **liota/generated_local_uuid_of_edge_system/response**
+* Publish and Subscribe QoS will be **One**


Is this default configuration specific to (a) or to all?

pmasrani · 2017-03-16T11:16:28Z

examples/mqtt/dcc_comms/aws_iot/simulated_home_topic_per_metric.py

+
+# ----------------------------------------------------------------------------------------------------------------
+# In this example, we demonstrate how data for a simulated metric generating
+# random numbers can be directed to GenericMqtt data center component using Liota.


"GenericMqtt "? Update comment.

pmasrani · 2017-03-17T07:11:44Z

examples/mqtt/dcc_comms/aws_iot/simulated_home_auto_gen_topic.py

+
+# ----------------------------------------------------------------------------------------------------------------
+# In this example, we demonstrate how data for a simulated metric generating
+# random numbers can be directed to GenericMqtt data center component using Liota.


GenericMqtt?

pmasrani · 2017-03-17T07:12:51Z

examples/mqtt/dcc_comms/aws_iot/simulated_home_auto_gen_topic.py

+    #  Creating EdgeSystem
+    edge_system = Dell5KEdgeSystem(config['EdgeSystemName'])
+    #  Encapsulates Identity
+    identity = Identity(config['broker_root_ca_cert'], None, None,


It is difficult to understand what None arguments are. Can you name the arguments?

pmasrani · 2017-03-17T09:16:43Z

liota/lib/utilities/identity.py

+        self.password = password
+        self.cert_file = cert_file
+        self.key_file = key_file
+        log.debug("Created Identity.")


For debugging, these kind of logs are not very useful. It is better to provide more information in debug logs like with what username the identity is created etc.

Venkat2811 added 5 commits January 17, 2017 20:09

GenericMqtt Dcc, example using AWS IoT and added README.md for MQTT

d148c00

updated

13bad45

updated

bd87d7b

updated

b184f21

updated

5a68126

KohliDev suggested changes Jan 27, 2017

View reviewed changes

Venkat2811 added 5 commits January 27, 2017 21:28

Merge branch 'master' into mqtt-dcc-new

972dc2b

removed identity module and other changes

2fb5a20

updated readme

d12b610

updated readme

2caeeeb

updated

25e7bc4

KohliDev reviewed Feb 1, 2017

View reviewed changes

Venkat2811 added 2 commits February 2, 2017 01:27

removed Identity and added Credentials in utility

efe4cfa

corrections

6a5e111

Venkat2811 referenced this pull request Feb 1, 2017

Added read_liota_config utility method

f070817

KohliDev reviewed Feb 6, 2017

View reviewed changes

Venkat2811 added 2 commits February 6, 2017 14:56

updated and README and other suggested changes

2745406

client_id bug fix

e6c6fa4

Venkat2811 mentioned this pull request Feb 13, 2017

Problems installing Liota on a Python virtualenv #85

Open

pmasrani reviewed Feb 19, 2017

View reviewed changes

Venkat2811 added 9 commits February 20, 2017 00:41

suggested changes as per review

06d706e

updated default pub-sub topic

2c4fdf2

various changes and basic DCC

32ea616

updated

09a7fc2

updated

90cc2a4

Merge branch 'master' into mqtt-dcc-new

4be166b

moved store_edge_system_uuid to utility

93a8418

Update sampleProp.conf

68015e4

resolving conflicts

14ceb15

Venkat2811 added 2 commits March 8, 2017 17:17

updated mqtt in device_disc to latest changes

b29da78

deleted basic DCC and ThingWorx

0b619ea

Venkat2811 mentioned this pull request Mar 8, 2017

Adding AWS DCC in liota #63

Open

Venkat2811 added 2 commits March 8, 2017 18:34

updated comments

49a7948

renaming

a729d94

Venkat2811 changed the title ~~GenericMqtt DCC, Example using AWSIoT, README~~ AWSIoT DCC, examples, README Mar 9, 2017

Venkat2811 added 6 commits March 9, 2017 11:08

returning paho's client_id is best

74c7aa6

mess_attr > msg_attr

fd0c89c

updated comment

8960a91

updated comment

3c70dbc

Merge branch 'master' into mqtt-dcc-new

c138fc5

Merge branch 'master' into mqtt-dcc-new

b9f44de

KohliDev reviewed Mar 15, 2017

View reviewed changes

KohliDev approved these changes Mar 15, 2017

View reviewed changes

KohliDev reviewed Mar 15, 2017

View reviewed changes

addressed review comments

1723ebb

pmasrani approved these changes Mar 17, 2017

View reviewed changes

addressed review comments

5674f12

KohliDev merged commit b67d1e7 into vmware-archive:master Mar 18, 2017

		LIOTA offers MQTT protocol as transport at both Device & DCC ends via ![MqttDeviceComms](/liota/device_comms/mqtt_device_comms.py) & ![MqttDccComms](/liota/dcc_comms/mqtt_dcc_comms.py).


		## QoS

		LIOTA also supports configuration of QoS related parameters like in_flight size, queue_size and retry timeout using QoSDetails class.


		## Credentials and TLS Configurations


		(b) Use custom single publish and subscribe topic for an EdgeSystem, its Devices and Metrics. Along with custom topics, other parameters (QoS, retain_flag ,etc.,) can be referred from ![Property File](/examples/mqtt/aws_iot/awsSampleProp.conf).

		- In the above two cases, MQTT message's payload MUST be self-descriptive so that subscriber can subscribe process accordingly to a single topic by parsing payload.



		# Random number generator, simulating living room temperature readings.
		def living_room_temperature():



		### Configuration for Non-ProjectICE Scenario
		![GenericMqtt DCC](/liota/dccs/generic_mqtt.py) is a Data Center Component to connect with MQTT brokers using LIOTA in non-ProjectICE scenarios. Options (a), (b), (c) and (d) mentioned in the above section

		@@ -41,10 +41,8 @@
		from liota.entities.devices.simulated_device import SimulatedDevice


		reg_entity_child.parent = reg_entity_parent

		def _get_entity_hierarchy(self, reg_entity):

AWSIoT DCC, examples, README #71

AWSIoT DCC, examples, README #71

Conversation

Venkat2811 commented Jan 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KohliDev Jan 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KohliDev Feb 1, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Venkat2811 Feb 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Venkat2811 Feb 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Venkat2811 Feb 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Venkat2811 Feb 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KohliDev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Venkat2811 commented Jan 17, 2017 •

edited

Loading

KohliDev Jan 27, 2017 •

edited

Loading

KohliDev Feb 1, 2017 •

edited

Loading

Venkat2811 Feb 19, 2017 •

edited

Loading

Venkat2811 Feb 19, 2017 •

edited

Loading

Venkat2811 Feb 19, 2017 •

edited

Loading

Venkat2811 Feb 19, 2017 •

edited

Loading