Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update colors #307

Merged
merged 2 commits into from
Apr 24, 2024
Merged

fix: update colors #307

merged 2 commits into from
Apr 24, 2024

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Apr 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

  • Token --cds-global-color-construction-1100 is missing
  • Token --cds-global-color-yellow-1000 have value hsl(40, 32%, 14%).
  • Token --cds-global-color-red-1000 have value hsl(7, 10%, 17%).
  • Token --cds-global-color-red-900 have value hsl(9, 100%, 22%).
  • Token --cds-global-color-jade-1000 have value hsl(160, 69%, 19%).
  • Token --cds-global-color-jade-900 have value hsl(160, 70%, 21%).
  • Token --cds-alias-utility-red (dark theme) have value --cds-global-color-red-300.

Issue Number: CDE-1848

What is the new behavior?

  • Token --cds-global-color-construction-1100 have value hsl(200, 31%, 13%).
  • Token --cds-global-color-yellow-1000 have value hsl(40, 100%, 13%).
  • Token --cds-global-color-red-1000 have value hsl(9, 100%, 22%).
  • Token --cds-global-color-red-900 have value hsl(9, 100%, 28%).
  • Token --cds-global-color-jade-1000 have value hsl(160, 69%, 14%).
  • Token --cds-global-color-jade-900 have value hsl(160, 70%, 18%).
  • Token --cds-alias-utility-red (dark theme) have value --cds-global-color-red-500.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

github-actions bot commented Apr 23, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov valentin-mladenov marked this pull request as ready for review April 23, 2024 13:38
@valentin-mladenov valentin-mladenov requested a review from a team April 23, 2024 13:38
@valentin-mladenov valentin-mladenov merged commit 5c8b522 into main Apr 24, 2024
2 checks passed
@valentin-mladenov valentin-mladenov deleted the fix-colors_cde-1848 branch April 24, 2024 11:56
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants